feat(datastore): Support for retrying Datastore transactions with the previous transaction id.#4342
Open
pcostell wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
Open
feat(datastore): Support for retrying Datastore transactions with the previous transaction id.#4342pcostell wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
pcostell wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
Conversation
… transactions wtih a previous transaction id. Change-Id: Id8a1aae10109d6d9531b8911631ad00e7014470b
…ion retries using spring.cloud.gcp.datastore.previous-transaction-retry-enabled. Change-Id: Ib23c2d4199fdccaf88eef83fc12e0085d40fe34a
prathmeshcc
added a commit
that referenced
this pull request
Mar 3, 2026
…-core (#4342) This PR establishes a clean code quality baseline for the Spring Boot 4.0 and Spring Framework 7.0 migration by resolving all formatting and checkstyle violations in the core module. Key Improvements: 1. Checkstyle Compliance * Applied final modifiers to classes and parameters to satisfy DesignForExtension and FinalParameters rules. * Resolved HiddenField violations by renaming setter parameters (e.g., scopes -> scopesList). * Fixed Javadoc formatting by adding mandatory empty lines before block tags (@param, @return) and correcting continuation indentation. * Enforced strict 80-character line limit across all core source files and Javadocs. 2. Project Infrastructure * Upgraded fmt-maven-plugin to 2.29 with google-java-format 1.27.0 to support Java 17 syntax while maintaining consistency. * Globally excluded junit-vintage-engine from spring-boot-starter-test to prevent GraalVM initialization issues with legacy JUnit 4 infrastructure. 3. AOT & Reflection Hints * Updated GcpRuntimeHints to provide comprehensive reflection hints for Spring Data domain classes (Page, Slice, Sort) required for Native Image support. Verification: * Successfully executed full verify lifecycle: ./mvnw verify -pl spring-cloud-gcp-core. * Confirmed 0 Checkstyle violations and 11/11 passing unit tests.
prathmeshcc
added a commit
that referenced
this pull request
Mar 3, 2026
…-core (#4342) This PR establishes a clean code quality baseline for the Spring Boot 4.0 and Spring Framework 7.0 migration by resolving all formatting and checkstyle violations in the core module. Key Improvements: 1. Checkstyle Compliance * Applied final modifiers to classes and parameters to satisfy DesignForExtension and FinalParameters rules. * Resolved HiddenField violations by renaming setter parameters (e.g., scopes -> scopesList). * Fixed Javadoc formatting by adding mandatory empty lines before block tags (@param, @return) and correcting continuation indentation. * Enforced strict 80-character line limit across all core source files and Javadocs. 2. Project Infrastructure * Upgraded fmt-maven-plugin to 2.29 with google-java-format 1.27.0 to support Java 17 syntax while maintaining consistency. * Globally excluded junit-vintage-engine from spring-boot-starter-test to prevent GraalVM initialization issues with legacy JUnit 4 infrastructure. 3. AOT & Reflection Hints * Updated GcpRuntimeHints to provide comprehensive reflection hints for Spring Data domain classes (Page, Slice, Sort) required for Native Image support. Verification: * Successfully executed full verify lifecycle: ./mvnw verify -pl spring-cloud-gcp-core. * Confirmed 0 Checkstyle violations and 11/11 passing unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4262.
Allows Datastore transaction using the @transactional decorator to be retried using @retryable while properly propagating the previous transaction id.