Skip to content
This repository was archived by the owner on Mar 16, 2026. It is now read-only.

add generation for pagerduty addon, extension, maintenance_window, response_play, ruleset_rule, service_dependency, service_integration and improve all other resource generators#1095

Closed
v0lumehi wants to merge 2 commits intoGoogleCloudPlatform:masterfrom
v0lumehi:master

Conversation

@v0lumehi
Copy link
Copy Markdown
Contributor

Hey guys! I added a lot of new resources to this provider.
I implemented a workaround to generate service_dependency resources until #1051 is fixed.

…ponse_play, ruleset_rule, service_dependency, service_integration and improve all other resource generators
@v0lumehi
Copy link
Copy Markdown
Contributor Author

We need to wait with merging until heimweh/go-pagerduty#68 has been merged.

@github-actions github-actions bot added the Stale label Dec 20, 2021
@robbat2
Copy link
Copy Markdown

robbat2 commented Jun 12, 2024

@v0lumehi is it okay if I split this?

  1. naming of resources, you kept removing the prefixes along with the whitespace to underscore change; I need the prefixes to avoid collisions; but the underscore change is good
  2. then just the new resources.

It does work rebased here.

@v0lumehi
Copy link
Copy Markdown
Contributor Author

@v0lumehi is it okay if I split this?

  1. naming of resources, you kept removing the prefixes along with the whitespace to underscore change; I need the prefixes to avoid collisions; but the underscore change is good

  2. then just the new resources.

It does work rebased here.

Yes sure. Sounds good to me

@github-actions github-actions bot removed the Stale label Jun 14, 2024
@github-actions github-actions bot added the Stale label Aug 16, 2024
@sergeylanzman sergeylanzman enabled auto-merge (squash) March 26, 2025 21:47
@slevenick slevenick closed this Mar 16, 2026
auto-merge was automatically disabled March 16, 2026 20:12

Pull request was closed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants