docs(range), feat(range): corrige quelques coquilles dans la documentation et proposition d'améliorations#1407
Open
7studio wants to merge 5 commits intoGouvernementFR:mainfrom
Open
docs(range), feat(range): corrige quelques coquilles dans la documentation et proposition d'améliorations#14077studio wants to merge 5 commits intoGouvernementFR:mainfrom
7studio wants to merge 5 commits intoGouvernementFR:mainfrom
Conversation
Contributor
|
Merci @7studio pour cette PR, Je suis ok avec tous tes points, et ça m'a l'air top, sauf le dernier. Si tu peux retirer ce changement, je pousserai la PR en 1.15 keryan |
keryanS
requested changes
Apr 14, 2026
Contributor
Author
|
Hello @keryanS, J'ai supprimé le dernier commit et ajouté la correction que tu as demandé sur la branche. Je pousserais l'idée du groupe de champs dès que la 1.15 sera là 😉 |
keryanS
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Voici une petite PR pour :
URL pour tester le dysfonctionnement actuel : https://www.systeme-de-design.gouv.fr/v1.14/storybook/index.html?path=/story/range--range-story&args=size:sm&globals=viewport:lg
Je profite de cette PR pour proposer deux améliorations :
privilégier l'utilisation d'un ensemble de champs viarole="groupau double aria-labelledby sur les éléments HTML<input>. Cela permet d’alléger la vocalisation et d'éviter de faire pointer learia-labelledbysur son propre élément (je n'avais jamais vu ça avant).