Skip to content

Add dark theme support and new configuration options#199

Merged
Hargne merged 17 commits intoHargne:devfrom
lararojasmr:master
Jun 25, 2025
Merged

Add dark theme support and new configuration options#199
Hargne merged 17 commits intoHargne:devfrom
lararojasmr:master

Conversation

@lararojasmr
Copy link
Copy Markdown
Contributor

Introduces a dark theme stylesheet and the ability to toggle themes via a new theme configuration option. Added includeConsoleLogOrigin setting to toggle logging origins in reports and fixed minor CSS inlining logic. Updated documentation and type definitions accordingly.

Introduces a dark theme stylesheet and the ability to toggle themes via a new `theme` configuration option. Added `includeConsoleLogOrigin` setting to toggle logging origins in reports and fixed minor CSS inlining logic. Updated documentation and type definitions accordingly.
Added a "prepare" script to streamline the npm lifecycle by running the build process automatically. This ensures the package is built during preparation steps, improving consistency and workflow.
The "build" and "prepare" scripts now directly invoke the bundling process, bypassing the test step. This simplifies the build workflow for cases where tests are not required.
Copy link
Copy Markdown
Owner

@Hargne Hargne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋🏻
Interesting addition! Funny thing is that we used to have a dark theme, which was then removed in later versions.

Have a look through my comments.

Comment thread src/htmlreporter.ts Outdated
Comment thread yarn.lock
Comment thread src/htmlreporter.ts Outdated
Comment thread src/types/index.d.ts Outdated
@lararojasmr
Copy link
Copy Markdown
Contributor Author

Al changes were made!. Let me know if you see anything else!

@lararojasmr lararojasmr requested a review from Hargne June 19, 2025 01:42
@Hargne
Copy link
Copy Markdown
Owner

Hargne commented Jun 19, 2025

Great!

FYI: I reverted the prettier commit as it touched pretty much all files in the entire project.
ℹ️ In the future: You can download prettier to VSCode and set it to format on save with the default settings (no need for a configuration).

I also noticed the tests are failing do to the changes made. You will need to add useCssFile: true to the styleOverridePath test (htmlreporter.test.ts line 68)

@lararojasmr
Copy link
Copy Markdown
Contributor Author

Great!

FYI: I reverted the prettier commit as it touched pretty much all files in the entire project. ℹ️ In the future: You can download prettier to VSCode and set it to format on save with the default settings (no need for a configuration).

I also noticed the tests are failing do to the changes made. You will need to add useCssFile: true to the styleOverridePath test (htmlreporter.test.ts line 68)

I'm using IntelliJIdea, I have install prettier plugin, but not with auto-save enabled because few time ago it gave me more problem than solutions hehe.

@lararojasmr
Copy link
Copy Markdown
Contributor Author

image Done!

Copy link
Copy Markdown
Owner

@Hargne Hargne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 Cool.
We're on the home stretch now :)

Comment thread README.md Outdated
@lararojasmr
Copy link
Copy Markdown
Contributor Author

@Hargne all is it now :) Let me know when it's ready please :) Thanks!

@lararojasmr lararojasmr requested a review from Hargne June 23, 2025 15:17
Copy link
Copy Markdown
Owner

@Hargne Hargne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 🚀

@Hargne Hargne self-requested a review June 24, 2025 08:30
@Hargne
Copy link
Copy Markdown
Owner

Hargne commented Jun 24, 2025

I saw that the build step is failing due to the added prepare script. Let me have a check..

Comment thread package.json Outdated
@lararojasmr lararojasmr requested a review from Hargne June 24, 2025 20:00
@Hargne Hargne changed the base branch from master to dev June 25, 2025 07:57
@Hargne Hargne merged commit ff6f2cc into Hargne:dev Jun 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants