add define to remove health fields#3067
Merged
Geokureli merged 2 commits intoHaxeFlixel:devfrom Mar 11, 2024
Merged
Conversation
Contributor
|
that’s honestly more better then what I did, my bad for the original message on it 😅 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #3065
I wasn't happy with the deprecation message of "you don't need it anymore, because you can extend", that's not what redundant means, the field should have never been added, to begin with.
I've added the defines: FLX_NO_HEALTH to remove it, and it's inversion: FLX_HEALTH. this way people can remove it in their projects now and add their own health system. when flixel 6.0.0 is released FLX_NO_HEALTH will be true by default, and FLX_HEALTH will be it's inversion so people can easily fix old projects