Skip to content

Add basic semantic PHP support#35

Merged
Helweg merged 1 commit intoHelweg:mainfrom
coandco:add_semantic_php
Mar 28, 2026
Merged

Add basic semantic PHP support#35
Helweg merged 1 commit intoHelweg:mainfrom
coandco:add_semantic_php

Conversation

@coandco
Copy link
Copy Markdown
Contributor

@coandco coandco commented Mar 28, 2026

Summary

Added basic semantic PHP parsing.

Changes

  • Modified types.rs to add .php and .inc files
  • Added PHP nodes to is_semantic_node and is_comment_node in parser.rs
  • Added .inc to the list of general filetypes gotten in src/config/constants.ts
  • Wrote some PHP parse tests in tests/native.test.ts
  • Updated documentation to reflect the new PHP support

Testing

How were these changes tested?

  • Unit tests added/updated
  • Manual testing performed
  • Build passes (npm run build)
  • Typecheck passes (npm run typecheck)
  • Tests pass (npm run test:run)
  • Lint passes (npm run lint)

Release Labels

  • Added at least one release category label (feature, bug, performance, documentation, dependencies, refactor, test, chore, or skip-changelog)
  • Added at most one semver label (semver:major, semver:minor, semver:patch) when needed

Related Issues

Fixes #34

@github-actions github-actions bot added dependencies Dependency updates documentation Documentation changes test Test changes labels Mar 28, 2026
@Helweg Helweg added feature New feature or capability semver:minor New feature (minor bump) labels Mar 28, 2026
Copy link
Copy Markdown
Owner

@Helweg Helweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated locally on the PR branch.

  • npm run build passed
  • npm run typecheck passed
  • npm run lint passed
  • cargo test passed
  • npm run test:run passed on a clean rerun

The change set matches the repo's documented scope for basic PHP semantic parsing support. PHP call-graph support remains out of scope for this PR and can follow separately.

@Helweg Helweg mentioned this pull request Mar 28, 2026
@Helweg Helweg merged commit d509df1 into Helweg:main Mar 28, 2026
6 of 7 checks passed
@Helweg Helweg mentioned this pull request Mar 28, 2026
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Dependency updates documentation Documentation changes feature New feature or capability semver:minor New feature (minor bump) test Test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Add semantic PHP support

2 participants