fix: rebuild native addon before release test scripts#38
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensure the release-gate test scripts rebuild the native addon before Vitest runs so local
npm run test:runandnpm run test:coveragedo not reuse a stale.nodebinary after Rust changes.Changes
pretest:runto invokenpm run build:nativebeforevitest runpretest:coverageto invokenpm run build:nativebeforevitest run --coverageTesting
How were these changes tested?
npm run build)npm run typecheck)npm run test:run)npm run lint)Exact validation results:
npm run build✅npm run typecheck✅npm run lint✅npm run test:run✅ (25 files, 478 tests passed)cargo fmt --check✅cargo clippy -- -D warnings✅cargo test✅ (58 passed)npm run eval:smoke✅ (Hit@5=0.00%,MRR@10=0.0000,p95=0.178ms)npm run test:coverage✅ (25 files, 478 tests passed)tests/call-graph.test.tsPHP call extraction assertions pass after the script-triggered native rebuildtests/retrieval-benchmark.test.tsremained green under coverage on this branch (meets Hit@5 and latency budgets); no non-PHP benchmark regression was observed from this changeRelease Labels
feature,bug,performance,documentation,dependencies,refactor,test,chore, orskip-changelog)semver:major,semver:minor,semver:patch) when neededRelated Issues
N/A