fix: 'fetch': key not found: "HOMEBREW_GITHUB_PACKAGES_AUTH" (KeyError)#21302
Merged
MikeMcQuaid merged 1 commit intoHomebrew:mainfrom Dec 22, 2025
Merged
fix: 'fetch': key not found: "HOMEBREW_GITHUB_PACKAGES_AUTH" (KeyError)#21302MikeMcQuaid merged 1 commit intoHomebrew:mainfrom
MikeMcQuaid merged 1 commit intoHomebrew:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a KeyError that occurs when HOMEBREW_GITHUB_PACKAGES_AUTH is not set in the environment. The issue arose when HOMEBREW_DOCKER_REGISTRY_BASIC_AUTH_TOKEN is set to the special value "none", which causes brew.sh to unset the HOMEBREW_GITHUB_PACKAGES_AUTH variable (line 1045 in brew.sh). The fix provides a default empty string for this optional authentication variable.
- Adds a default empty string parameter to
ENV.fetch()forHOMEBREW_GITHUB_PACKAGES_AUTH
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?Hi,
after #21278 was merged, I tested the main branch inside our company.
I can't tell what different since it published my initial PR, but now I got an error if I set
HOMEBREW_DOCKER_REGISTRY_BASIC_AUTH_TOKENtonone:After configure a default value in ENV.fetch, everything works as expected. (tested internally).