Skip to content

extend/ENV: add extra secret type#21933

Merged
MikeMcQuaid merged 1 commit intoHomebrew:mainfrom
GunniBusch:env-improve-detection
Apr 5, 2026
Merged

extend/ENV: add extra secret type#21933
MikeMcQuaid merged 1 commit intoHomebrew:mainfrom
GunniBusch:env-improve-detection

Conversation

@GunniBusch
Copy link
Copy Markdown
Contributor


  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests (excluding integration tests) for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

Just some small fix for one discussion in Homebrew/homebrew-core#275950

Copilot AI review requested due to automatic review settings April 5, 2026 18:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Homebrew’s environment “sensitive key” detection to treat authentication-related environment variables as sensitive, affecting which env vars are cleared/redacted during operations like command execution and formula stages.

Changes:

  • Expand ENV.sensitive? matching to include keys containing auth.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Library/Homebrew/extend/ENV.rb
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

In future: please don't use e.g. chore: prefixes as we don't use that format here.

@MikeMcQuaid MikeMcQuaid changed the title chore: improve env handling extend/ENV: add extra secret type Apr 5, 2026
@MikeMcQuaid MikeMcQuaid enabled auto-merge April 5, 2026 18:55
@GunniBusch
Copy link
Copy Markdown
Contributor Author

GunniBusch commented Apr 5, 2026

Thanks!

In future: please don't use e.g. chore: prefixes as we don't use that format here.

sure. just wanted to make sure since this actually reduces the amounts of envs, and probably better to not give wrong thoughts

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Apr 5, 2026
Merged via the queue into Homebrew:main with commit 93c4691 Apr 5, 2026
39 of 40 checks passed
@GunniBusch GunniBusch deleted the env-improve-detection branch April 5, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants