Merged
Conversation
github-actions
bot
added
long build
Contributor
Author
|
(I believe there's nothing wrong with my addition; it's just that the |
Contributor
Author
|
Now that #218030 has been merged, I'll sync this real quick... |
github-actions
bot
added
automerge-skip
github-actions
bot
removed
the
automerge-skip
bevanjkay
added
the
CI-syntax-only
Contributor
Author
|
@bevanjkay Thanks for the prompt triage! Is there anything else I can do to help this PR getting merged? |
chenrui333
added
the
automerge-skip
ZhongRuoyu
reviewed
Apr 6, 2025
github-actions
bot
removed
the
automerge-skip
ZhongRuoyu
approved these changes
Apr 7, 2025
Member
ZhongRuoyu
left a comment
ZhongRuoyu
left a comment
There was a problem hiding this comment.
This looks better to me, thanks @rami3l!
MikeMcQuaid
reviewed
Apr 7, 2025
Member
MikeMcQuaid
left a comment
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Thanks for the PR! Still needs a bit of work here.
MikeMcQuaid
reviewed
Apr 8, 2025
github-actions
bot
added
the
autosquash
github-actions
bot
removed
the
autosquash
6 tasks
daeho-ro
approved these changes
Apr 13, 2025
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?Hello, it's me again on behalf of the rustup team here!
We have noticed a common issue with a regular
brewuser developing with Rust:rustupinstallation (either installed with or withoutbrew).brew install rust(usually implicitly as a build dependency), the binaries provided by that package will shadow existingrustup-provided binaries.rustup-installed toolchains/components might seem "gone", causing subtle breakages that are essentially out of our control.We already have warnings when
brew install rusthappens beforerustupis installed, but unfortunately checking the existence of abrew-managed Rust installation will be much more costly afterwards, so I'm making this PR hoping to further inform potential users of this conflict in the "after" case.Hopefully closes rust-lang/rustup#1236.