Skip to content

dart-sdk: support two level namespace for macOS, dart-sass 1.99.0 (new formula)#275692

Merged
BrewTestBot merged 4 commits intomainfrom
dart-sass-1.98.0
Apr 9, 2026
Merged

dart-sdk: support two level namespace for macOS, dart-sass 1.99.0 (new formula)#275692
BrewTestBot merged 4 commits intomainfrom
dart-sass-1.98.0

Conversation

@daeho-ro
Copy link
Copy Markdown
Member

@daeho-ro daeho-ro commented Apr 2, 2026


  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>?
  • Is your test running fine brew test <formula>?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

Revisit

@github-actions github-actions Bot added autosquash Automatically squash pull request commits according to Homebrew style. new formula PR adds a new formula to Homebrew/homebrew-core labels Apr 2, 2026
@github-actions github-actions Bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Apr 2, 2026
Comment thread Formula/d/dart-sass.rb Outdated
@github-actions github-actions Bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Apr 2, 2026
@github-actions github-actions Bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Apr 2, 2026
@daeho-ro daeho-ro force-pushed the dart-sass-1.98.0 branch 2 times, most recently from c84df8a to 5950cd1 Compare April 2, 2026 08:30
@daeho-ro
Copy link
Copy Markdown
Member Author

daeho-ro commented Apr 2, 2026

I have reverted the latest changes, it doesn't work as expected.

@daeho-ro
Copy link
Copy Markdown
Member Author

daeho-ro commented Apr 4, 2026

I have tried to build with aot-snapshot for macos, but audit failes,

dart-sass
  * Libraries were compiled with a flat namespace.
    This can cause linker errors due to name collisions and
    is often due to a bug in detecting the macOS version.
      /opt/homebrew/Cellar/dart-sass/1.98.0/libexec/sass.aot

and it doesn't respect MACOSX_DEPLOYMENT_TARGET. Not sure how to push target version.

btw, 1.99.0 is out, should update.

@daeho-ro daeho-ro changed the title dart-sass 1.98.0 (new formula) dart-sass 1.99.0 (new formula) Apr 4, 2026
@github-actions github-actions Bot added the CI-linux-self-hosted Build on Linux self-hosted runner label Apr 5, 2026
@daeho-ro daeho-ro added CI-no-bottle-cache Disable bottle cache ready to merge PR can be merged once CI is green and removed CI-no-bottle-cache Disable bottle cache labels Apr 5, 2026
@daeho-ro daeho-ro requested a review from cho-m April 5, 2026 12:02
@daeho-ro daeho-ro removed the ready to merge PR can be merged once CI is green label Apr 5, 2026
@daeho-ro daeho-ro changed the title dart-sass 1.99.0 (new formula) dart-sdk: support two level namespace for macOS, dart-sass 1.99.0 (new formula) Apr 5, 2026
@daeho-ro daeho-ro added the ready to merge PR can be merged once CI is green label Apr 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2026

🤖 An automated task has requested bottles to be published to this PR.

Caution

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions Bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Apr 9, 2026
@BrewTestBot BrewTestBot enabled auto-merge April 9, 2026 09:03
@BrewTestBot BrewTestBot added this pull request to the merge queue Apr 9, 2026
Merged via the queue into main with commit 72d0ceb Apr 9, 2026
22 checks passed
@BrewTestBot BrewTestBot deleted the dart-sass-1.98.0 branch April 9, 2026 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-linux-self-hosted Build on Linux self-hosted runner CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core ready to merge PR can be merged once CI is green

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants