Add Hindi locale parity#1738
Conversation
- Introduced a new goal prompt template for adding or updating Humanizer locales, providing clear instructions and workflow references. - Expanded the parity checklist to clarify evidence lanes, surface inventory, and required proof subrows, ensuring comprehensive coverage for locale parity. - Updated Urdu epic learnings to include detailed failure modes and reusable rules for common pitfalls in locale implementation, focusing on Arabic-script differences, plural rules, and number scales.
…der and clarifying culture code usage
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (25)
💤 Files with no reviewable changes (1)
📝 WalkthroughSummary by CodeRabbitRelease Notes
WalkthroughThis PR adds comprehensive Hindi locale support to Humanizer alongside a phrase-clock evening period feature. Changes include schema and runtime updates for evening day periods, a complete Hindi locale definition file, augmented test data across multiple coverage datasets, and fourteen new Hindi-specific test suites validating clock notation, date/number formatting, and humanization with gender support. ChangesEvening Period Feature and Hindi Locale Support
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
There was a problem hiding this comment.
Pull request overview
This PR adds Hindi (hi) locale parity coverage for Humanizer’s localization surfaces, including exact-output tests for formatting, dates, numbers, clock notation, compass directions, lists, and units. It also includes unrelated workflow/tooling removals that appear outside the stated Hindi locale scope.
Changes:
- Added Hindi locale data coverage and exact-output tests.
- Extended shared locale theory/matrix data with Hindi cases.
- Removed Flow-Next/Ralph/Codex workflow files and related contributor instructions.
Reviewed changes
Copilot reviewed 176 out of 289 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
tests/Humanizer.Tests/Localisation/hi/* |
Adds Hindi-specific exact-output tests. |
tests/Humanizer.Tests/Localisation/Locale*TheoryData.cs |
Adds Hindi rows to shared locale theory data. |
.agents/skills/add-locale/references/goal-prompt-template.md |
Adds a reusable add-locale goal prompt template. |
CLAUDE.md, AGENTS.md |
Removes Flow-Next contributor instructions. |
.flow/**, .codex/**, scripts/ralph/** |
Deletes repository workflow/tooling metadata and scripts. |
tools/verification-signoff.md |
Updates a verification signoff row. |
Comments suppressed due to low confidence (1)
.flow/config.json:1
- This deletes the tracked Flow-Next configuration/state, while the PR is scoped to adding Hindi locale parity. Removing the repository's task metadata/tooling is unrelated to the locale change and can break contributors or automation that rely on
.flow; please restore these files or split the workflow removal into a separately described PR.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 26237cc809
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0ed3fd92e8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
hi) locale YAML coverage across list formatting, formatter phrases, number words/parsing/formatting, ordinals, dates, clock notation, compass, and calendar monthstests/Humanizer.Tests/Localisation/hiValidation
dotnet test tests/Humanizer.SourceGenerators.Tests/Humanizer.SourceGenerators.Tests.csproj --framework net11.0dotnet test tests/Humanizer.Tests/Humanizer.Tests.csproj --framework net10.0dotnet test tests/Humanizer.Tests/Humanizer.Tests.csproj --framework net11.0dotnet test tests/Humanizer.Tests/Humanizer.Tests.csproj --framework net8.0dotnet pack src/Humanizer/Humanizer.csproj -c Release -o artifacts/locale-parity-validationdotnet format Humanizer.slnx --verify-no-changes --verbosity diagnosticgit diff --checkNotes:
net48tests were skipped because this host is non-Windows.net11.0in this checkout.