This repository was archived by the owner on Mar 20, 2025. It is now read-only.
Merged
Conversation
Member
Author
|
todo： rollback go mod changes for proto related. |
xiaohui249
reviewed
Jan 27, 2022
xiaohui249
left a comment
xiaohui249
left a comment
There was a problem hiding this comment.
依赖目录vendor也提交了，造成很多依赖文件变更，这个目录是否有必要提交？
Member
Author
|
改动是因为ginko（ut）框架升级而fabric没升级这个框架的依赖。upstream那边我已经提交了相关issue。我们这边确实应该考虑回滚。
|
Sam Yuan
***@***.***
|
Signature is customized by Netease Mail Master
On 01/27/2022 11:36, Xiao Hui wrote:
@xiaohui249 commented on this pull request.
依赖目录vendor也提交了，造成很多依赖文件变更，这个目录是否有必要提交？
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
SamYuan1990
force-pushed
the
sm2sm3testing
branch
from
f95443c to
0951d36
Compare
9 tasks
Signed-off-by: Sam Yuan <yy19902439@126.com>
SamYuan1990
force-pushed
the
sm2sm3testing
branch
from
dcb93c9 to
3042068
Compare
davidkhala
reviewed
Feb 11, 2022
|
|
||
| ccssm2 "github.com/Hyperledger-TWGC/ccs-gm/sm2" | ||
| "github.com/hyperledger/fabric/bccsp/sm2" | ||
| . "github.com/onsi/ginkgo" |
Member
There was a problem hiding this comment.
ginkgo和gomega这两个包是原来fabric自带的么？
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add some test cases for sm2 package
fix sm3 bug