Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Most certainly,I am following the threads. I am on vacation right now, so may be a few days until I get a chance to dive into this. But I will try ASAP. |
|
Awesome thank you! I bumped the kia_uvo side to have the "framework" tested with the other users. Based on your interest I will leave this side alone for now and focus on framing up how the config_flow will work. In theory I can build an release that without any region supporting OTP since it wouldn't interfere. |
|
|
||
| class OTP_NOTIFY_TYPE(Enum): | ||
| EMAIL = "EMAIL" | ||
| PHONE = "PHONE" |
There was a problem hiding this comment.
needs to be SMS.
DEBUG:hyundai_kia_connect_api.KiaUvoApiUSA:hyundai_kia_connect_api - Send OTP Response {"status":{"statusCode":1,"errorType":3,"errorCode":1164,"errorMessage":"notifyType must be EMAIL or SMS"}}
There was a problem hiding this comment.
Good catch. The old code this is removing had phone and email. I will adjust.
There was a problem hiding this comment.
I have adjusted. Please review and let me know if looks correct. For when it presents options I assume that still states Phone not SMS?
There was a problem hiding this comment.
i think the UI options behavior is controlled by the kia_uvo repo? like this right?
https://github.com/Hyundai-Kia-Connect/kia_uvo/pull/1373/files#diff-23b6f7993e8ff6b9446bac1fbcde0acfda2fb36bb27589000f21de2bc110c277R293
There was a problem hiding this comment.
raw api response
{"status":{"statusCode":0,"errorType":0,"errorCode":0,"errorMessage":"Success with response body"},"payload":{"otpKey":"XXX","hasEmail":true,"hasPhone":true,"email":"*****","phone":"() **","emailVerifyStatus":true,"phoneVerifyStatus":true}}
There was a problem hiding this comment.
Yes UI will be on that side but what options the client presents must come from here since not everyone sets up all types.
| email=payload.get("email"), | ||
| phone=payload.get("phone"), | ||
| has_email=bool(payload.get("hasEmail")), | ||
| has_phone=bool(payload.get("hasPhone")), |
There was a problem hiding this comment.
i think these attributes need updating to has_sms and sms
for more information, see https://pre-commit.ci
|
@renatkh another user has tested and given feedback. We are chatting on discord if you want to join. I'm going to merge since this works with test scripts. I have a draft pr on the Kia uvo side for adding config flow. |
3 participants
@renatkh Are you able to take a look at this and see thoughts? I am sure I have missed things. Any feedback or commits are welcome. Happy to have you take this part over if interested.