fix(ui): move pagination data into script tag#3155
Closed
crivetimihai wants to merge 1 commit intomainfrom
Closed
Conversation
2 tasks
69d4377 to
0b32b8d
Compare
Collaborator
|
@gcgoncalves - can you please resolve conflicts? |
bb96266 to
6f6e7df
Compare
7 tasks
6f6e7df to
91a0c14
Compare
91a0c14 to
4f9be56
Compare
dc4d935 to
90056e8
Compare
Collaborator
|
Changing from 1.1.0 to 1.0.0, to make the plugins intractable. |
90056e8 to
f1e9df0
Compare
f1e9df0 to
ecdec1d
Compare
Collaborator
|
@gcgoncalves - I can approve this PR after eslint and pytest are fixed. |
7e427c6 to
3806131
Compare
Signed-off-by: Gabriel Costa <gabrielcg@proton.me>
3806131 to
dda1b6a
Compare
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Bug-fix PR
📌 Summary
paginationData()once as a global function inadmin.js, with all its methods.data-*attributes;Closes #2975
Closes #3040
🔁 Reproduction Steps
🐞 Root Cause
Jinja was escaping JS content inside a x-data attribute.
💡 Fix Description
Moved the JS object inside a script tag to prevent escaping, then referred to it from the
x-dataattribute.🧪 Verification
make lintmake testmake coverage✅ Checklist
make black isort pre-commit)