Restores pinned dependency versions for Rust#3844
Conversation
Signed-off-by: Dmitry Zakharov <zakharov@ibm.com>
Signed-off-by: Dmitry Zakharov <zakharov@ibm.com>
Signed-off-by: Dmitry Zakharov <zakharov@ibm.com>
Signed-off-by: Dmitry Zakharov <zakharov@ibm.com>
Signed-off-by: Dmitry Zakharov <zakharov@ibm.com>
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Dmitry Zakharov <zakharov@ibm.com>
Signed-off-by: Dmitry Zakharov <zakharov@ibm.com>
Signed-off-by: Dmitry Zakharov <zakharov@ibm.com>
Signed-off-by: Dmitry Zakharov <zakharov@ibm.com>
dawid-nowak
left a comment
There was a problem hiding this comment.
I think we still need to add Cargo.lock files from rust_plugins/* to git , don't we?
There was a problem hiding this comment.
@dima-zakharov fast-test-server still missing cargo.lock
|
do the local |
I checked these files they do not specify any deps in them. So we can add the lock files, but we can use them as is. |
|
@brian-hussey Please review, the changes are very small, no code changes, just pinning the dependencies with .lock files and maturin version is specified in --dev section of main pyproject.toml. And try merge if you are happy, I am not allowed to merge this PR myself. |
|
I applied Admin override to merge this PR after all checks passed and getting multiple PR reviews from the team. |
* Restore cargo lock file Signed-off-by: Dmitry Zakharov <zakharov@ibm.com> * pin maturin version Signed-off-by: Dmitry Zakharov <zakharov@ibm.com> * stub file addtion Signed-off-by: Dmitry Zakharov <zakharov@ibm.com> * restore Cargo.lock files Signed-off-by: Dmitry Zakharov <zakharov@ibm.com> * update stub files Signed-off-by: Dmitry Zakharov <zakharov@ibm.com> * Follow suggestion of CI manifest check Signed-off-by: Dmitry Zakharov <zakharov@ibm.com> * Ugrade aws-lc-rs as found by CI CVE checks Signed-off-by: Dmitry Zakharov <zakharov@ibm.com> * Ugrade rustls-webpki as found by CI CVE checks Signed-off-by: Dmitry Zakharov <zakharov@ibm.com> * Remove before refactor layout Cargo.lock file Signed-off-by: Dmitry Zakharov <zakharov@ibm.com> * pin libs Signed-off-by: Dima Zakharov <zakharov@ibm.com> --------- Signed-off-by: Dmitry Zakharov <zakharov@ibm.com> Signed-off-by: Dima Zakharov <zakharov@ibm.com>
Pin libraries versions.
🔗 Related Issue
Pin rust libraries and maturin version as discussed in Slack
📝 Summary
🏷️ Type of Change
🧪 Verification
make rust-buildmake testmake coverage✅ Checklist
make black isort pre-commit)📓 Notes (optional)
Chore task no functionality changes.