Skip to content

Adds components to main top navbar#4678

Open
byrnec30 wants to merge 9 commits intoIBM:epic/ui-rewritefrom
byrnec30:cb-NavBarFeature
Open

Adds components to main top navbar#4678
byrnec30 wants to merge 9 commits intoIBM:epic/ui-rewritefrom
byrnec30:cb-NavBarFeature

Conversation

@byrnec30
Copy link
Copy Markdown

@byrnec30 byrnec30 commented May 8, 2026

🔗 Related Issue

Closes #

#4464 (comment)

📝 Summary

What does this PR do and why?
This PR:

changes the layout of the main top navbar:

  • adds a search input bar that is highlighted on keyboard shortcut, and changes the suggested shortcut default text depending on the user's OS. The search logic is not yet implemented in this PR.
  • Adds the version number of the latest release
  • adds links to github and documentation, as set out in the issue guideline
  • Adds in a profile dropdown with: log-in username, Theme, Settings, Logout. Profile image is not yet implemented
  • adds unit tests for new components
  • Adds one string needed in PR

Screenshot 2026-05-07 at 12 29 00 Screenshot 2026-05-07 at 12 28 52

🏷️ Type of Change

  • Bug fix
  • Feature / Enhancement
  • Documentation
  • Refactor
  • Chore (deps, CI, tooling)
  • Other (describe below)

🧪 Verification

Check Command Status
Lint suite make lint
Unit tests make test
Coverage ≥ 80% make coverage

✅ Checklist

  • Code formatted (make black isort pre-commit)
  • Tests added/updated for changes
  • Documentation updated (if applicable)
  • No secrets or credentials committed

📓 Notes (optional)

Screenshots, design decisions, or additional context.

clarebyrne added 9 commits May 8, 2026 16:29
Signed-off-by: Clare Byrne <clare.byrne1@ibm.com>
Signed-off-by: Clare Byrne <clare.byrne1@ibm.com>
Signed-off-by: Clare Byrne <clare.byrne1@ibm.com>
Signed-off-by: Clare Byrne <clare.byrne1@ibm.com>
Signed-off-by: Clare Byrne <clare.byrne1@ibm.com>
Signed-off-by: Clare Byrne <clare.byrne1@ibm.com>
Signed-off-by: Clare Byrne <clare.byrne1@ibm.com>
Signed-off-by: Clare Byrne <clare.byrne1@ibm.com>
Signed-off-by: Clare Byrne <clare.byrne1@ibm.com>
@byrnec30 byrnec30 force-pushed the cb-NavBarFeature branch from 971863e to e551ce5 Compare May 8, 2026 15:29
<div className="flex items-center gap-2">
<HeaderQuickNav />
<span className="hidden text-sm font-medium text-muted-foreground sm:inline">
v{appPackage.version}
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this version may not match the actual app release version, is there a better source of truth for the version displayed here?

return (
<DropdownMenu>
<DropdownMenuTrigger asChild>
{/* TODO: User photo/avatar data does not appear to be available in the current frontend. Using fallback button for now. */}
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: source for photo or avatar?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants