remove unused metadataFieldName #377

pdurbin · pdurbin · commit f32c8b5c2419 · 2025-03-21T16:01:21.000-04:00
diff --git a/src/sections/dataset/dataset-metadata/dataset-metadata-fields/DatasetMetadataFieldValueFormatted.tsx b/src/sections/dataset/dataset-metadata/dataset-metadata-fields/DatasetMetadataFieldValueFormatted.tsx
@@ -34,7 +34,6 @@ export function DatasetMetadataFieldValueFormatted({
   const { t } = useTranslation(metadataBlockName)
 
   const valueFormatted = metadataFieldValueToDisplayFormat(
-    metadataFieldName,
     metadataFieldValue,
     metadataBlockDisplayFormatInfo
   )
@@ -54,7 +53,6 @@ export function DatasetMetadataFieldValueFormatted({
 }
 
 export function metadataFieldValueToDisplayFormat(
-  metadataFieldName: string,
   metadataFieldValue: DatasetMetadataFieldValueModel,
   metadataBlockInfo?: MetadataBlockInfoDisplayFormat
 ): string {
diff --git a/tests/component/sections/dataset/dataset-metadata/DatasetMetadata.spec.tsx b/tests/component/sections/dataset/dataset-metadata/DatasetMetadata.spec.tsx
@@ -206,7 +206,6 @@ describe('DatasetMetadata', () => {
           const metadataFieldNameTranslated = t[metadataBlock.name].datasetField[metadataFieldName]
             .name as string
           const metadataFieldValueString = metadataFieldValueToDisplayFormat(
-            metadataFieldName,
             metadataFieldValue,
             metadataBlockInfoMock
           )
diff --git a/tests/component/sections/dataset/dataset-summary/SummaryFields.spec.tsx b/tests/component/sections/dataset/dataset-summary/SummaryFields.spec.tsx
@@ -39,7 +39,6 @@ describe('DatasetSummary', () => {
           summaryFieldDescription.should('exist')
 
           const summaryFieldValueString = metadataFieldValueToDisplayFormat(
-            summaryFieldName,
             summaryFieldValue,
             metadataBlockInfoMock
           )

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,6 @@ export function DatasetMetadataFieldValueFormatted({`
`34`	`34`	`const { t } = useTranslation(metadataBlockName)`
`35`	`35`
`36`	`36`	`const valueFormatted = metadataFieldValueToDisplayFormat(`
`37`		`- metadataFieldName,`
`38`	`37`	`metadataFieldValue,`
`39`	`38`	`metadataBlockDisplayFormatInfo`
`40`	`39`	`)`
`@@ -54,7 +53,6 @@ export function DatasetMetadataFieldValueFormatted({`
`54`	`53`	`}`
`55`	`54`
`56`	`55`	`export function metadataFieldValueToDisplayFormat(`
`57`		`- metadataFieldName: string,`
`58`	`56`	`metadataFieldValue: DatasetMetadataFieldValueModel,`
`59`	`57`	`metadataBlockInfo?: MetadataBlockInfoDisplayFormat`
`60`	`58`	`): string {`
Original file line number	Diff line number	Diff line change
`@@ -206,7 +206,6 @@ describe('DatasetMetadata', () => {`
`206`	`206`	`const metadataFieldNameTranslated = t[metadataBlock.name].datasetField[metadataFieldName]`
`207`	`207`	`.name as string`
`208`	`208`	`const metadataFieldValueString = metadataFieldValueToDisplayFormat(`
`209`		`- metadataFieldName,`
`210`	`209`	`metadataFieldValue,`
`211`	`210`	`metadataBlockInfoMock`
`212`	`211`	`)`
Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,6 @@ describe('DatasetSummary', () => {`
`39`	`39`	`summaryFieldDescription.should('exist')`
`40`	`40`
`41`	`41`	`const summaryFieldValueString = metadataFieldValueToDisplayFormat(`
`42`		`- summaryFieldName,`
`43`	`42`	`summaryFieldValue,`
`44`	`43`	`metadataBlockInfoMock`
`45`	`44`	`)`