-
Notifications
You must be signed in to change notification settings - Fork 21
View guestbook and download file with guestbook #926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sekmiller
merged 40 commits into
develop
from
896-add-terms-of-use-and-guestbook-to-file-download
Apr 10, 2026
Merged
Changes from 38 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
8fb9658
feat: view guestbook and download file with guestbook
ChengShi-1 1ac21f6
feat: add submit multiple files with guestbook
ChengShi-1 d256ae4
fix: dataset test error
ChengShi-1 3ceaf98
feat: tests
ChengShi-1 54f7a0e
feat: write storybook and more tests
ChengShi-1 18691cb
fix: test useGetDatasetVersionDiff.spec
ChengShi-1 9bf054e
fix: increase test coverage, and disable edit names and email in gues…
ChengShi-1 152cfcd
fix: remove .only
ChengShi-1 3a8f6a3
fix: increase test coverage
ChengShi-1 6faaeb4
fix: increase test coverage
ChengShi-1 9c59921
fix: optimize the structure
ChengShi-1 983268d
fix: tests failing
ChengShi-1 b67702a
add e2e test, update download modal
ChengShi-1 9e1b4bd
fix: test custom terms
ChengShi-1 b876d24
package.json update
ChengShi-1 e368ef0
feat: add clear selection to edit guestbook page
ChengShi-1 d14878d
fix: storybook and fix tests
ChengShi-1 6540c6f
update with js-dataverse
ChengShi-1 d5ae0cd
fix: e2e test file download
ChengShi-1 20f6131
fix: Copilot review
ChengShi-1 6261406
fix: test error
ChengShi-1 90c375e
fix: small fix on removing custom question url
ChengShi-1 6ece880
cherry pick the guestbook review
ChengShi-1 6bf616b
fix: use signedURL Download for no guestbook files
ChengShi-1 51318d3
fix: use e2e errpr
ChengShi-1 55cbbaf
fix: add format to download api
ChengShi-1 1a2d5e2
Merge branch 'develop' into 896-add-terms-of-use-and-guestbook-to-fil…
ChengShi-1 ec641f5
chore: remove console.log
ChengShi-1 6eef084
fix: change jsDatasetMapper downloadurls still back to persistenID
ChengShi-1 dba18f8
fix: Test errors on jsDatasetMapper downloadurls
ChengShi-1 c53bf6e
fix: update the guestbookID and other info to AccessFile component
ChengShi-1 5146f52
fix: duplicated text and close modal before error
ChengShi-1 4e93a2e
fix: dataset file download
ChengShi-1 78a5bbb
fix: Added an [enabled] prevent multiple calls of GetGuestbook and cl…
ChengShi-1 47cfd49
feat: disallow guestbook if it's a draft or edit permission
ChengShi-1 0a0a9f3
fix: flaky test in collectionItemPanel
ChengShi-1 87c3919
fix: permission has to change in tests
ChengShi-1 56c70ce
fix: one permission didn't change
ChengShi-1 03a1008
Merge branch 'develop' into 896-add-terms-of-use-and-guestbook-to-fil…
ChengShi-1 7c2b5e0
update js-dataverse to point to merged version
ekraffmiller File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| { | ||
| "title": "Dataset Guestbooks", | ||
| "errors": { | ||
| "getGuestbook": "Something went wrong getting the guestbook. Try again later." | ||
| }, | ||
| "preview": { | ||
| "title": "Preview Guestbook", | ||
| "description": "Upon downloading files the guestbook asks for the following information.", | ||
| "guestbookNameLabel": "Guestbook Name", | ||
| "guestbookDataLabel": "Collected Data", | ||
| "guestbookDataTip": "User data collected by the guestbook.", | ||
|
Comment on lines
+10
to
+11
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This looks like a duplicate of the next two items (collectedDataLabel, collectedDataTip) can we remove them? |
||
| "accountInformation": "Account Information", | ||
| "customQuestionsLabel": "Custom Questions", | ||
| "required": "Required", | ||
| "optional": "Optional" | ||
| }, | ||
| "create": { | ||
| "fields": { | ||
| "dataCollected": { | ||
| "label": "Data Collected", | ||
| "help": "Dataverse account information that will be collected when a user downloads a file. Check the ones that will be required.", | ||
| "options": { | ||
| "name": "Name", | ||
| "email": "Email", | ||
| "institution": "Institution", | ||
| "position": "Position" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dependency is pinned to a PR-specific build (
2.1.0-pr429.f4e6bd4). This is risky for reproducible builds since PR build tags can be moved/removed, and it makes it harder to reason about what API surface is guaranteed. Prefer upgrading to a released semver version (or a stable pre-release) once the upstream change is merged, and document/track this temporary pin if it must remain for now.