View guestbook and download file with guestbook #926
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| { | ||
| "title": "Dataset Guestbooks", | ||
| "errors": { | ||
| "getGuestbook": "Something went wrong getting the guestbook. Try again later." | ||
| }, | ||
| "preview": { | ||
| "title": "Preview Guestbook", | ||
| "description": "Upon downloading files the guestbook asks for the following information.", | ||
| "guestbookNameLabel": "Guestbook Name", | ||
| "guestbookDataLabel": "Collected Data", | ||
| "guestbookDataTip": "User data collected by the guestbook.", | ||
|
Comment on lines
+10
to
+11
Contributor
There was a problem hiding this comment. This looks like a duplicate of the next two items (collectedDataLabel, collectedDataTip) can we remove them? |
||
| "collectedDataLabel": "Collected Data", | ||
| "collectedDataTip": "User data collected by the guestbook.", | ||
| "accountInformation": "Account Information", | ||
| "customQuestionsLabel": "Custom Questions", | ||
| "required": "Required", | ||
| "optional": "Optional" | ||
| }, | ||
| "create": { | ||
| "fields": { | ||
| "dataCollected": { | ||
| "label": "Data Collected", | ||
| "help": "Dataverse account information that will be collected when a user downloads a file. Check the ones that will be required.", | ||
| "options": { | ||
| "name": "Name", | ||
| "email": "Email", | ||
| "institution": "Institution", | ||
| "position": "Position" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| { | ||
| "title": "Libros de visitas del dataset", | ||
| "errors": { | ||
| "getGuestbook": "Algo salió mal al obtener el libro de visitas. Inténtalo de nuevo más tarde." | ||
| }, | ||
| "preview": { | ||
| "title": "Vista previa del libro de visitas", | ||
| "description": "Al descargar ficheros, el libro de visitas solicita la siguiente información.", | ||
| "guestbookNameLabel": "Nombre del libro de visitas", | ||
| "guestbookDataLabel": "Datos recopilados", | ||
| "guestbookDataTip": "Datos del usuario recopilados por el libro de visitas.", | ||
| "collectedDataLabel": "Datos recopilados", | ||
| "collectedDataTip": "Datos del usuario recopilados por el libro de visitas.", | ||
| "accountInformation": "Información de la cuenta", | ||
| "customQuestionsLabel": "Preguntas personalizadas", | ||
| "required": "Obligatorio", | ||
| "optional": "Opcional" | ||
| }, | ||
| "create": { | ||
| "fields": { | ||
| "dataCollected": { | ||
| "label": "Datos recopilados", | ||
| "help": "Información de la cuenta de Dataverse que se recopilará cuando un usuario descargue un fichero. Marca las que serán obligatorias.", | ||
| "options": { | ||
| "name": "Nombre", | ||
| "email": "Correo electrónico", | ||
| "institution": "Institución", | ||
| "position": "Cargo" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| export type GuestbookAnswerDTO = { | ||
| id: number | string | ||
| value: string | string[] | ||
| } | ||
|
|
||
| export type GuestbookResponseDTO = { | ||
| guestbookResponse: { | ||
| name?: string | ||
| email?: string | ||
| institution?: string | ||
| position?: string | ||
| answers?: GuestbookAnswerDTO[] | ||
| } | ||
| } | ||
| export interface AccessRepository { | ||
| submitGuestbookForDatasetDownload: ( | ||
| datasetId: number | string, | ||
| answers: GuestbookResponseDTO | ||
| ) => Promise<string> | ||
| submitGuestbookForDatafileDownload: ( | ||
| fileId: number | string, | ||
| answers: GuestbookResponseDTO | ||
| ) => Promise<string> | ||
| submitGuestbookForDatafilesDownload: ( | ||
| fileIds: Array<number>, | ||
| answers: GuestbookResponseDTO | ||
| ) => Promise<string> | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import { AccessRepository, GuestbookResponseDTO } from '../repositories/AccessRepository' | ||
|
|
||
| export function submitGuestbookForDatafileDownload( | ||
| accessRepository: AccessRepository, | ||
| fileId: number | string, | ||
| answers: GuestbookResponseDTO | ||
| ): Promise<string> { | ||
| return accessRepository.submitGuestbookForDatafileDownload(fileId, answers) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import { AccessRepository, GuestbookResponseDTO } from '../repositories/AccessRepository' | ||
|
|
||
| export function submitGuestbookForDatafilesDownload( | ||
| accessRepository: AccessRepository, | ||
| fileIds: Array<number>, | ||
| answers: GuestbookResponseDTO | ||
| ): Promise<string> { | ||
| return accessRepository.submitGuestbookForDatafilesDownload(fileIds, answers) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import { AccessRepository, GuestbookResponseDTO } from '../repositories/AccessRepository' | ||
|
|
||
| export function submitGuestbookForDatasetDownload( | ||
| accessRepository: AccessRepository, | ||
| datasetId: number | string, | ||
| answers: GuestbookResponseDTO | ||
| ): Promise<string> { | ||
| return accessRepository.submitGuestbookForDatasetDownload(datasetId, answers) | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dependency is pinned to a PR-specific build (
2.1.0-pr429.f4e6bd4). This is risky for reproducible builds since PR build tags can be moved/removed, and it makes it harder to reason about what API surface is guaranteed. Prefer upgrading to a released semver version (or a stable pre-release) once the upstream change is merged, and document/track this temporary pin if it must remain for now.