Merge pull request #12034 from GlobalDataverseCommunityConsortium/otherIdentifierBug

alternativeIdentifierType attribute in DataCite XML was always set to :unav for otherId fields from citation metadatablock

Author: scolapasta

src/main/java/edu/harvard/iq/dataverse/pidproviders/doi/XmlMetadataTemplate.java

@@ -927,10 +927,9 @@ private void writeAlternateIdentifiers(XMLStreamWriter xmlw, DvObject dvObject)
         }
 
         for (DatasetFieldCompoundValue otherIdentifier : otherIdentifiers) {
-            String identifierType = null;
+            String identifierType = ":unav";
             String identifier = null;
             for (DatasetField subField : otherIdentifier.getChildDatasetFields()) {
-                identifierType = ":unav";
                 switch (subField.getDatasetFieldType().getName()) {
                 case DatasetFieldConstant.otherIdAgency:
                     identifierType = subField.getValue();