Skip to content

Commit aae1cbd

Browse files
committed
fix for revoke
1 parent f5b77ea commit aae1cbd

2 files changed

Lines changed: 3 additions & 8 deletions

File tree

src/main/java/edu/harvard/iq/dataverse/ManagePermissionsPage.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,6 @@ public RoleAssignment getSelectedRoleAssignment() {
151151
}
152152

153153
public void setSelectedRoleAssignment(RoleAssignment selectedRoleAssignment) {
154-
logger.info("Selecting ra: " + selectedRoleAssignment.toString());
155154
this.selectedRoleAssignment = selectedRoleAssignment;
156155
}
157156

@@ -188,11 +187,6 @@ public List<RoleAssignmentRow> initRoleAssignments() {
188187
}
189188

190189
public void removeRoleAssignment() {
191-
if(selectedRoleAssignment != null) {
192-
logger.info("revoking " + selectedRoleAssignment.toString());
193-
} else {
194-
logger.info("No RA to revoke");
195-
}
196190
revokeRole(selectedRoleAssignment);
197191

198192
if (dvObject instanceof Dataverse) {

src/main/webapp/permissions-manage.xhtml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -274,8 +274,9 @@
274274
<span class="glyphicon glyphicon-warning-sign text-danger"/> <span class="text-danger">#{bundle['dataverse.permissions.usersOrGroups.removeBtn.confirmation']}</span>
275275
</p>
276276
<div class="button-block">
277-
<p:commandButton value="#{bundle.continue}" styleClass="btn btn-default" onclick="PF('confirmation').hide()"
278-
action="#{managePermissionsPage.removeRoleAssignment()}"
277+
<p:commandButton value="#{bundle.continue}" styleClass="btn btn-default" oncomplete="PF('confirmation').hide()"
278+
action="#{managePermissionsPage.removeRoleAssignment()}"
279+
process="@this"
279280
update=":#{p:resolveClientId('rolesPermissionsForm:configureSettings', view)} assignedRoles roleAssignmentHistory @([id$=Messages])" />
280281
<button class="btn btn-link" onclick="PF('confirmation').hide()" type="button">
281282
#{bundle.cancel}

0 commit comments

Comments
 (0)