File Upload: file upload for collection with metadblocks that have required, single, controlled vocab fails

[sbarbosadataverse]

What steps does it take to reproduce the issue?

Navigate to dataverse.harvard.edu and select the "add data" "new dataset" option at the TOP of the page
change the host from "Harvard Dataverse" to collection Climate Change and Health Research Coordinating Center (CAFE) Collection

fill in required fields, upload files, and select save.

File doesn't show up on save.

• When does this issue occur?

When using "add data" and "new dataset" at the TOP of the production page, within a collection
*inside CAFE collection, but using "add data" "new dataset" on top page toolbar

• Which page(s) does it occurs on?
  add dataset deposit page when inside a collection but using top level "add data-new dataset" option

• What happens?
  Files disappear when you hit save and don't show up in the saved draft

• To whom does it occur (all users, curators, superusers)?

All

• What did you expect to happen?

Uploaded files are ingested/uploaded on save

Which version of Dataverse are you using?

Any related open or closed issues to this bug report?

Screenshots:

No matter the issue, screenshots are always welcome.

To add a screenshot, please use one of the following formats and/or methods described here:

• https://help.github.com/en/articles/file-attachments-on-issues-and-pull-requests

[landreev]

Is it working if you try to only create the dataset, without uploading files in the same step?
Is the above still happening today?

[sbarbosadataverse]

@landreev still happening today. this ticket is is directly related to files included. I tested and without files i can create the dataset

[scolapasta]

I tried and was able to reproduce - I saw it occur both when using the general Add Dataser button, but also when using the specific one that already has the correct host dataverse collection.

I also (temporarily removed the two metatdatablocks that are specific to CAFE) and then things worked correctly.

The two blocks:
Metadata About Data Sources
Metadata About Data Location

With either one (or both) enabled, am seeing the behavior from the image above.

[scolapasta]

OK, so some more data - the two behaviors that are seen depend on whether direct upload or not:
if direct upload, file stays in not uploaded state as in the image
if not direct upload, file seems to load, but is not added to list (pre save).

[scolapasta]

OK, so the smoking gun...
These metadatablocks have fields that:
a) are controlled vocab
b) do not allow multiple
c) are required

There's only one other metadatablock which has a field like that and it exhibits the same behavior. Clearly, something is failing the validation and so it doesn't proceed with the upload as it should.

In the meanwhile, I discovered another workaround (the forst being to upload files AFTER create). You can give these fields default values in the template and then it works as expected.

[scolapasta]

Actually one more workaround - just fill out those two fields first BEFORE you try to upload the file. Then the upload also works as expected.

[scolapasta]

Also, I went ahead and changed the title - my guess is Sonia wasn't seeing it when they used the direct button because they filled out the metadata BEFORE trying to upload.