Display Order not being returned correctly for Dataset Authors

[ekraffmiller]

The authors are being returned in a different order from how they are saved in the metadata form.

What steps does it take to reproduce the issue?
Create a dataset with multiple authors, either through the JSF UI or the SPA.
For example create two authors,

• Admin, Dataverse
• Owner, Dataverse

• What happens?
  In the search results page, the authors are displayed in the correct order, both in JSF and SPA. In the Dataset page, the order of the authors is reversed, both in JSF and SPA.

Which version of Dataverse are you using?
latest development version

Search result in the Collection Page:

JSF Dataset Page, with authors reversed in the Citation and Metadata:

SPA Dataset Page, with authors reversed in the Citation, but in the correct order in the Metadata:

[qqmyers]

FWIW: #12026 is a fix for a test that started failing because the order of the description value fields aren't keeping their order - I wonder if the problem is with compound fields.

[qqmyers]

@ekraffmiller - I don't think the issue is with saving fields. Compound fields have a datasetfieldcompoundvalue and those appear to be getting valid displayorders. (The authorName field in the datafieldvalue table always has the relative displayorder of 0 if its the only child of that datasetfieldtype in the compound value.) I think
select cv.id, cv.displayorder, dft.id, dft.name from datasetfieldcompoundvalue cv, datasetfield df, datasetfieldtype dft where df.id=cv.parentdatasetfield_id and df.datasetfieldtype_id=dft.id order by cv.id desc; will show that multiple compound values do get sequential displayorders with multiple values. (At least they did on my test at QDR).

[ekraffmiller]

@qqmyers thanks, I am seeing the same thing in my local test, I will update the bug description.

[qqmyers]

FWIW: My guess for a fix would be to add the displayOrder to

dataverse/src/main/java/edu/harvard/iq/dataverse/DatasetVersion.java

Lines 991 to 1023 in f2a250f

	public List<DatasetAuthor> getDatasetAuthors() {
	//TODO get "List of Authors" from datasetfieldvalue table
	List <DatasetAuthor> retList = new ArrayList<>();
	for (DatasetField dsf : this.getDatasetFields()) {
	Boolean addAuthor = true;
	if (dsf.getDatasetFieldType().getName().equals(DatasetFieldConstant.author)) {
	for (DatasetFieldCompoundValue authorValue : dsf.getDatasetFieldCompoundValues()) {
	DatasetAuthor datasetAuthor = new DatasetAuthor();
	for (DatasetField subField : authorValue.getChildDatasetFields()) {
	if (subField.getDatasetFieldType().getName().equals(DatasetFieldConstant.authorName)) {
	if (subField.isEmptyForDisplay()) {
	addAuthor = false;
	}
	datasetAuthor.setName(subField);
	}
	if (subField.getDatasetFieldType().getName().equals(DatasetFieldConstant.authorAffiliation)) {
	datasetAuthor.setAffiliation(subField);
	}
	if (subField.getDatasetFieldType().getName().equals(DatasetFieldConstant.authorIdType)){
	datasetAuthor.setIdType(subField.getRawValue());
	}
	if (subField.getDatasetFieldType().getName().equals(DatasetFieldConstant.authorIdValue)){
	datasetAuthor.setIdValue(subField.getDisplayValue());
	}
	}
	if (addAuthor) {
	retList.add(datasetAuthor);
	}
	}
	}
	}
	return retList;
	}

and either in that method (probably better) or at

dataverse/src/main/java/edu/harvard/iq/dataverse/DataCitation.java

Line 865 in f2a250f

dsv.getDatasetAuthors().stream().forEach((author) -> {

to sort by displayOrder. That doesn't explain why we're just now seeing an order problem unless something else has changed in how we get fields back from the database.

If that works, it's a fairly simple fix (size 3? 10?)