Skip to content

DANS/QDR ORE Bag PR with fix for collections#12212

Closed
qqmyers wants to merge 2 commits intoIQSS:developfrom
GlobalDataverseCommunityConsortium:DANS-QDR-merged_bag_changes_for_QA
Closed

DANS/QDR ORE Bag PR with fix for collections#12212
qqmyers wants to merge 2 commits intoIQSS:developfrom
GlobalDataverseCommunityConsortium:DANS-QDR-merged_bag_changes_for_QA

Conversation

@qqmyers
Copy link
Copy Markdown
Member

@qqmyers qqmyers commented Mar 12, 2026

What this PR does / why we need it: This PR includes a fix for the problems seen with collection creation/publication/deletion that appeared with #12167. It also has a minor merge fix for determining the hashtype to use when files are missing hash values in the database and removes an ignorehashes variable that was legacy from before Dataverse which doesn't ever set it to true.

Which issue(s) this PR closes:

  • Closes #

Special notes for your reviewer: This branch has all the #12167 changes. It is therefore not up to date with develop which has reverted all of those. I'm not sure how that should be handled.

FWIW: The fix for collections is basically to revert the update of permission time to run in the command transactions for collections while leaving datasets to work with it in a new transaction (~as appropriate for them since indexing is done asynchronously, in parallel with workflows, and adding old information from a shared context is a problem). Collection commands appear to rely on the call to update permission time to store required info for the collection (hard to track, but switching the permission time update to a separate transaction leads to errors in the log about not finding the alias of the collection). Changing that in the future seems like a useful thing to do.

Suggestions on how to test this: DANS has tested the minor fix for hash value type. To test the collections functionality, trying to create/publish/delete collections from the UI should work.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@qqmyers qqmyers moved this to Ready for Review ⏩ in IQSS Dataverse Project Mar 12, 2026
@qqmyers qqmyers added this to the 6.10 milestone Mar 12, 2026
@qqmyers qqmyers added Size: 3 A percentage of a sprint. 2.1 hours. GDCC: DANS related to GDCC work for DANS GDCC: QDR of interest to QDR labels Mar 12, 2026
@qqmyers qqmyers mentioned this pull request Mar 12, 2026
@sekmiller sekmiller self-assigned this Mar 12, 2026
@sekmiller sekmiller moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Mar 12, 2026
@sekmiller
Copy link
Copy Markdown
Contributor

Closed as included in 12213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GDCC: DANS related to GDCC work for DANS GDCC: QDR of interest to QDR Size: 3 A percentage of a sprint. 2.1 hours.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants