DANS/QDR ORE Bag PR with fix for collections#12212
Closed
qqmyers wants to merge 2 commits intoIQSS:developfrom
Closed
DANS/QDR ORE Bag PR with fix for collections#12212qqmyers wants to merge 2 commits intoIQSS:developfrom
qqmyers wants to merge 2 commits intoIQSS:developfrom
Conversation
Merged
Contributor
|
Closed as included in 12213 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This PR includes a fix for the problems seen with collection creation/publication/deletion that appeared with #12167. It also has a minor merge fix for determining the hashtype to use when files are missing hash values in the database and removes an ignorehashes variable that was legacy from before Dataverse which doesn't ever set it to true.
Which issue(s) this PR closes:
Special notes for your reviewer: This branch has all the #12167 changes. It is therefore not up to date with develop which has reverted all of those. I'm not sure how that should be handled.
FWIW: The fix for collections is basically to revert the update of permission time to run in the command transactions for collections while leaving datasets to work with it in a new transaction (~as appropriate for them since indexing is done asynchronously, in parallel with workflows, and adding old information from a shared context is a problem). Collection commands appear to rely on the call to update permission time to store required info for the collection (hard to track, but switching the permission time update to a separate transaction leads to errors in the log about not finding the alias of the collection). Changing that in the future seems like a useful thing to do.
Suggestions on how to test this: DANS has tested the minor fix for hash value type. To test the collections functionality, trying to create/publish/delete collections from the UI should work.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: