10217 source name harvesting client

[luddaniel]

What this PR does / why we need it:

This PR will help admin to customize their harvesting clients name in metadata source facet.
A new field called sourceName, a nullable TEXT, has been added.
If set, it will overload the nickName in metadata source facet while indexing harvested dataset.
This will allow to have many harvesting client to be under the same sourceName if wished.

Please have in mind that displaying nickName or sourceName requires to activate the feature flag index-harvested-metadata-source.

This PR contains some refactoring and update on guide documentation.

Which issue(s) this PR closes:

• Closes Add Source/Server name to OAI-PMH Harvesting clients #10217

Special notes for your reviewer:

I tested this code from user interface (Dashboard > create and edit havesting client popup) .
I tested this code from API also.
I was not able to test the HarvestingClientsIT in localhost.

My samples for testing :

{
"nickName": "CIRAD_1",
"dataverseAlias": "root",
"type": "oai",
"style": "dataverse",
"harvestUrl": "https://dataverse.cirad.fr/oai",
"archiveUrl": "https://dataverse.cirad.fr",
"archiveDescription": "This Dataset is harvested from our partners. Clicking the link will take you directly to the archival source of the data.",
"metadataFormat": "oai_dc",
"set": "entrepot_recherche_data_gouv",
"schedule": "none",
"allowHarvestingMissingCVV": false,
"useOaiIdentifiersAsPids": false
}

{
"nickName": "IRD",
"sourceName": "RDG Partners",
"dataverseAlias": "root",
"type": "oai",
"style": "dataverse",
"harvestUrl": "https://dataverse.ird.fr//oai",
"archiveUrl": "https://dataverse.ird.fr",
"archiveDescription": "This Dataset is harvested from our partners. Clicking the link will take you directly to the archival source of the data.",
"metadataFormat": "oai_dc",
"schedule": "none",
"allowHarvestingMissingCVV": false,
"useOaiIdentifiersAsPids": false
}

{
"nickName": "progedo",
"sourceName": "RDG Partners",
"dataverseAlias": "root",
"type": "oai",
"style": "default",
"harvestUrl": "https://data.progedo.fr/oai",
"archiveUrl": "https://data.progedo.fr",
"archiveDescription": "This Dataset is harvested from our partners. Clicking the link will take you directly to the archival source of the data.",
"metadataFormat": "oai_dc",
"schedule": "none",
"allowHarvestingMissingCVV": true,
"useOaiIdentifiersAsPids": false
}

Does this PR introduce a user interface change?:

The new field is visible in both creation and edition harvesting client popup :

Examples of harvesting result in metadata source :

Please note that both progedo and IRD are merged under "RDG Partners" in metadata source and CIRAD is displayed under CIRAD because the sourceName is not set.

Is there a release notes update needed for this change?

Yes

Preview doc changes:

• https://dataverse-guide--11217.org.readthedocs.build/en/11217/installation/config.html#feature-flags
• https://dataverse-guide--11217.org.readthedocs.build/en/11217/api/native-api.html#create-a-harvesting-client

[coveralls]

coverage: 22.727%. remained the same
when pulling f7c4c42 on Recherche-Data-Gouv:10217-source-name-harvesting-client
into f5f2c72 on IQSS:develop.

[luddaniel]

Thank you for the improvement @pdurbin

[pdurbin]

@luddaniel can you please look again at this release not snippet? I just rewrote it again, based on my updated understanding of the history of this feature. Thanks!

[pdurbin]

@luddaniel I ran the code and it seems to work fine. Please see individual comments in this review for changes I think we should make and other stuff to consider.

[pdurbin]

Tests are failing: https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-11217/

However, tests are failing on the develop branch too: https://jenkins.dataverse.org/job/IQSS-dataverse-develop/

Let's keep an eye on this (@luddaniel I realize you don't have visibility - #9916) as we get closer to moving this to "ready for QA".

[pdurbin]

We are close to releasing 6.6 and will be at code freeze (no more PRs merged) in a week on March 7th. With lots of merging going on I've already bumped the version of of this SQL script twice.

Mostly I want to communicate that with little time left, this PR might need to get bumped to 6.7. We'll see.

[landreev]

Yeah, V6.5.0.6 has already been merged; and it appears that there are multiple contenders for V6.5.0.7... So, some last minute renaming will be needed, depending on which one is ready to be merged first.

[pdurbin]

I think this is ready for QA. Approved!

There's an SQL script so let's keep on eye out for merge conflicts and bump the version as needed.

[ofahimIQSS]

Everything looks good here. - ready to merge once I see tests are passing (right now, jenkin has a long queue list)

[ofahimIQSS]

Getting a failure: https://jenkins.dataverse.org/blue/organizations/jenkins/IQSS-Dataverse-Develop-PR/detail/PR-11217/13/pipeline

Please advise.

[qqmyers]

Needs a merge to pick up the revert PR

[ofahimIQSS]

Needs a merge to pick up the revert PR

Merging away and seeing what jenkins has in store for us.