Skip to content

return all type totals regardless of types being returned#11347

Merged
ofahimIQSS merged 4 commits intodevelopfrom
11280-search-api-count-per-object
Mar 25, 2025
Merged

return all type totals regardless of types being returned#11347
ofahimIQSS merged 4 commits intodevelopfrom
11280-search-api-count-per-object

Conversation

@stevenwinship
Copy link
Copy Markdown
Contributor

What this PR does / why we need it: All totals counts should be returned regardless of the "type"(s) being requested in the filter

Which issue(s) this PR closes:#11280

Special notes for your reviewer:

Suggestions on how to test this: make various search api calls. See SearchIT tests

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?: included

Additional documentation:

@stevenwinship stevenwinship self-assigned this Mar 14, 2025
@github-actions github-actions Bot added FY25 Sprint 18 FY25 Sprint 18 (2025-02-26 - 2025-03-12) FY25 Sprint 19 FY25 Sprint 19 (2025-03-12 - 2025-03-26) GREI Re-arch Issues related to the GREI Dataverse rearchitecture Original size: 10 Size: 10 A percentage of a sprint. 7 hours. SPA These changes are required for the Dataverse SPA SPA.Q1 Not related to any specific Q1 feature Type: Bug a defect labels Mar 14, 2025
@stevenwinship stevenwinship moved this to In Progress 💻 in IQSS Dataverse Project Mar 14, 2025
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 14, 2025

Coverage Status

coverage: 22.595% (-0.001%) from 22.596%
when pulling c395ac6 on 11280-search-api-count-per-object
into eb8e91d on develop.

@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@stevenwinship stevenwinship removed their assignment Mar 17, 2025
@stevenwinship stevenwinship moved this from In Progress 💻 to Ready for Review ⏩ in IQSS Dataverse Project Mar 17, 2025
@github-actions

This comment has been minimized.

@github-actions
Copy link
Copy Markdown

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:11280-search-api-count-per-object
ghcr.io/gdcc/configbaker:11280-search-api-count-per-object

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@sekmiller sekmiller self-assigned this Mar 20, 2025
@sekmiller sekmiller moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Mar 20, 2025
+ "name,pounds,species,treats\n"
+ "Midnight,15,dog,milkbones\n"
+ "Tiger,17,cat,cat grass\n"
+ "Panther,21,cat,cat nip\n";
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cute

@github-project-automation github-project-automation Bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Mar 20, 2025
@sekmiller sekmiller removed their assignment Mar 20, 2025
@ofahimIQSS ofahimIQSS self-assigned this Mar 21, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Mar 21, 2025
@ofahimIQSS
Copy link
Copy Markdown
Contributor

tests passing, merging PR

@ofahimIQSS ofahimIQSS merged commit fb33fa4 into develop Mar 25, 2025
15 checks passed
@ofahimIQSS ofahimIQSS deleted the 11280-search-api-count-per-object branch March 25, 2025 16:27
@github-project-automation github-project-automation Bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Mar 25, 2025
@ofahimIQSS ofahimIQSS removed their assignment Mar 25, 2025
@pdurbin pdurbin added this to the 6.7 milestone Mar 25, 2025
@scolapasta scolapasta moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY25 Sprint 18 FY25 Sprint 18 (2025-02-26 - 2025-03-12) FY25 Sprint 19 FY25 Sprint 19 (2025-03-12 - 2025-03-26) GREI Re-arch Issues related to the GREI Dataverse rearchitecture Original size: 10 Size: 10 A percentage of a sprint. 7 hours. SPA.Q1 Not related to any specific Q1 feature SPA These changes are required for the Dataverse SPA Type: Bug a defect

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

Search API - Count per object

6 participants