Skip to content

Metrics Fix#11358

Merged
ofahimIQSS merged 2 commits intoIQSS:developfrom
GlobalDataverseCommunityConsortium:MetricsFix
Mar 25, 2025
Merged

Metrics Fix#11358
ofahimIQSS merged 2 commits intoIQSS:developfrom
GlobalDataverseCommunityConsortium:MetricsFix

Conversation

@qqmyers
Copy link
Copy Markdown
Member

@qqmyers qqmyers commented Mar 19, 2025

What this PR does / why we need it: One of the methods allowing the country code does not verify that the code is valid.

Which issue(s) this PR closes:

  • Closes #

Special notes for your reviewer:

Suggestions on how to test this: Try the affected method with a country code not in

@Transient private static Set<String> validCountryCodes = Stream
.of("a1", "a2", "o1", "ad", "ae", "af", "ag", "ai", "al", "am", "ao", "ap", "aq", "ar", "as", "at", "au", "aw", "ax", "az", "ba", "bb", "bd", "be", "bf", "bg", "bh", "bi", "bj", "bl", "bm", "bn", "bo", "bq", "br", "bs", "bt", "bv", "bw", "by", "bz", "ca", "cc", "cd", "cf", "cg", "ch", "ci", "ck", "cl", "cm", "cn", "co", "cr", "cu", "cv", "cw", "cx", "cy", "cz", "de", "dj", "dk", "dm", "do", "dz", "ec", "ee", "eg", "eh", "er", "es", "et", "eu", "fi", "fj", "fk",
"fm", "fo", "fr", "ga", "gb", "gd", "ge", "gf", "gg", "gh", "gi", "gl", "gm", "gn", "gp", "gq", "gr", "gs", "gt", "gu", "gw", "gy", "hk", "hm", "hn", "hr", "ht", "hu", "id", "ie", "il", "im", "in", "io", "iq", "ir", "is", "it", "je", "jm", "jo", "jp", "ke", "kg", "kh", "ki", "km", "kn", "kp", "kr", "kw", "ky", "kz", "la", "lb", "lc", "li", "lk", "lr", "ls", "lt", "lu", "lv", "ly", "ma", "mc", "md", "me", "mf", "mg", "mh", "mk", "ml", "mm", "mn", "mo",
"mp", "mq", "mr", "ms", "mt", "mu", "mv", "mw", "mx", "my", "mz", "na", "nc", "ne", "nf", "ng", "ni", "nl", "no", "np", "nr", "nu", "nz", "om", "pa", "pe", "pf", "pg", "ph", "pk", "pl", "pm", "pn", "pr", "ps", "pt", "pw", "py", "qa", "re", "ro", "rs", "ru", "rw", "sa", "sb", "sc", "sd", "se", "sg", "sh", "si", "sj", "sk", "sl", "sm", "sn", "so", "sr", "ss", "st", "sv", "sx", "sy", "sz", "tc", "td", "tf", "tg", "th", "tj", "tk", "tl", "tm", "tn", "to",
"tr", "tt", "tv", "tw", "tz", "ua", "ug", "um", "us", "uy", "uz", "va", "vc", "ve", "vg", "vi", "vn", "vu", "wf", "ws", "ye", "yt", "za", "zm", "zw")
and verify the response is 400 (as in the IT test).

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@qqmyers qqmyers moved this to Ready for Triage in IQSS Dataverse Project Mar 19, 2025
@qqmyers qqmyers added the Size: 3 A percentage of a sprint. 2.1 hours. label Mar 19, 2025
@scolapasta scolapasta moved this from Ready for Triage to Ready for Review ⏩ in IQSS Dataverse Project Mar 20, 2025
@scolapasta scolapasta added this to the 6.7 milestone Mar 20, 2025
@stevenwinship stevenwinship self-assigned this Mar 21, 2025
@stevenwinship stevenwinship moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Mar 21, 2025
@github-project-automation github-project-automation Bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Mar 21, 2025
@stevenwinship stevenwinship removed their assignment Mar 21, 2025
@ofahimIQSS ofahimIQSS self-assigned this Mar 21, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Mar 21, 2025
@cmbz cmbz added the FY25 Sprint 19 FY25 Sprint 19 (2025-03-12 - 2025-03-26) label Mar 21, 2025
ghost pushed a commit to DataverseNO/dataverse that referenced this pull request Mar 24, 2025
ghost pushed a commit to DataverseNO/dataverse that referenced this pull request Mar 25, 2025
@ofahimIQSS
Copy link
Copy Markdown
Contributor

tests passing, merging PR

@ofahimIQSS ofahimIQSS merged commit 97d2cbf into IQSS:develop Mar 25, 2025
12 checks passed
@github-project-automation github-project-automation Bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Mar 25, 2025
@ofahimIQSS ofahimIQSS removed their assignment Mar 25, 2025
@scolapasta scolapasta moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Mar 25, 2025
aliassheikh added a commit to DANS-KNAW/dataverse that referenced this pull request Mar 31, 2025
ghost pushed a commit to DataverseNO/dataverse that referenced this pull request Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY25 Sprint 19 FY25 Sprint 19 (2025-03-12 - 2025-03-26) Size: 3 A percentage of a sprint. 2.1 hours.

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

5 participants