11376 add version note to diff summary#11390
Merged
ofahimIQSS merged 5 commits intodevelopfrom Apr 9, 2025
Merged
Conversation
github-actions
Bot
added
FY25 Sprint 20
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
stevenwinship
moved this from Ready for Review ⏩
to In Review 🔎
in IQSS Dataverse Project
| JsonObjectBuilder jobVersion = new NullSafeJsonBuilder(); | ||
| jobVersion.add("versionNumber", originalVersion.getFriendlyVersionNumber()); | ||
| jobVersion.add("versionState", originalVersion.getVersionState().name()); | ||
| jobVersion.add("versionNote", originalVersion.getVersionNote()); |
Contributor
There was a problem hiding this comment.
Looks like versionNote can be null. Surround with if != null to prevent the field from being added when null.
Contributor
There was a problem hiding this comment.
never mind I didn't see the NullSafeJsonBuilder
stevenwinship
approved these changes
Apr 8, 2025
github-project-automation
Bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
Contributor
|
Looks good, merging.
|
github-project-automation
Bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Add the new Version Note to version differences and summary
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
You'll need to set the feature flag for enabling version notes
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: No
Additional documentation: none