MakeDataCount API may end up in infinite loop

[luddaniel]

Hi everyone :)
Our team identified a issue with api/admin/makeDataCount/:persistentId/updateCitationsForDataset?persistentId=$DOI that could end up in infinite loop if Datacite result is paginated.

While using Datacite API pagination by page number + using next link : it will keep sending the same content page after page 10 and next link will exists forever.
Moreover, using this method is limited to a retrieve of 10,000 records (After page 10, all pages display page content of page n°10)

Ex:
First page : https://api.datacite.org/events?doi=10.12763/SMDGR1&source=crossref&page[size]=1000

"meta": {
    "total": 10276,
    "total-pages": 11,

"links": {
    "self": "https://api.datacite.org/events?doi=10.12763/SMDGR1&source=crossref&page[size]=1000",
    "next": "https://api.datacite.org/events?doi=10.12763%2FSMDGR1&page%5Bnumber%5D=2&page%5Bsize%5D=1000"
  }

Page number 11 : https://api.datacite.org/events?doi=10.12763%2FSMDGR1&page%5Bnumber%5D=11&page%5Bsize%5D=1000
Still displays a next link :

"links": {
    "self": "https://api.datacite.org/events?doi=10.12763%2FSMDGR1&page%5Bnumber%5D=11&page%5Bsize%5D=1000",
    "next": "https://api.datacite.org/events?doi=10.12763%2FSMDGR1&page%5Bnumber%5D=11&page%5Bsize%5D=1000"
  }

This code is now using Datacite API pagination by Cursor that will remove next link at last page, fixing the infinite loop issue while increasing the search capability to its maximum.

[ofahimIQSS]

looks good - merging