Fix password script in base container image

[poikilotherm]

What this PR does / why we need it:

This PR replaces #11463 as I couldn't push changes to the fork branch.

Fixing a problem of a Dataverse application container not starting when running on Docker due to an already set password in a previous run.

Which issue(s) this PR closes:

• Closes Dead Dataverse after server restart #10998

Special notes for your reviewer:
If you normally start the Docker image with docker-compose and Docker is configured to restart all running Docker instances upon a system restart, the error occurs. This happens because the script specifies that if a program does not return exit 0, the script should terminate, and as a result, the entire startup process fails.

Suggestions on how to test this:
During the normal start using Docker, all three or at least one of the following parameters must be specified: LINUX_PASSWORD, PAYARA_ADMIN_PASSWORD, DOMAIN_PASSWORD.
Then, stop the containers but don't delete them. Now start them again and see if the startup stop failing.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Nope

Is there a release notes update needed for this change?:
Nope

Additional documentation:
None

[poikilotherm]

@pdurbin this is ready for review. As it is very important for containers but not touching any app code at all it is a very small PR. IMHO it should be OK to take a shortcut unless @ofahimIQSS wants to play with images 😄

[pdurbin]

I didn't test this but the fix looks reasonable (backports! fancy!).

I did tweak the "how to test" steps a bit for clarity.

[pdurbin]

all three or at least one of the following parameters must be specified: LINUX_PASSWORD, PAYARA_ADMIN_PASSWORD, DOMAIN_PASSWORD

@poikilotherm are there rules for these password? I don't see anything at https://guides.dataverse.org/en/6.6/container/base-image.html#tunables

I tried "foo" and got an error that it was too short (dev_dataverse | passwd: Authentication token manipulation error).

Then I tried this:

% git diff
diff --git a/docker-compose-dev.yml b/docker-compose-dev.yml
index 986c0a49f1..070317b071 100644
--- a/docker-compose-dev.yml
+++ b/docker-compose-dev.yml
@@ -9,6 +9,9 @@ services:
     restart: on-failure
     user: payara
     environment:
+      LINUX_PASSWORD: "correct horse battery staple"
+      PAYARA_ADMIN_PASSWORD: "correct horse battery staple"
+      DOMAIN_PASSWORD: "correct horse battery staple"
       DATAVERSE_DB_HOST: postgres
       DATAVERSE_DB_PASSWORD: secret
       DATAVERSE_DB_USER: ${DATAVERSE_DB_USER}

(I hope I'm doing this right, by the way.)

I got this error:

dev_dataverse         | passwd: Authentication token manipulation error
dev_dataverse         | passwd: password unchanged
dev_dataverse         | Changing password for payara.
dev_dataverse exited with code 10

[pdurbin]

Nevermind. I was able to reproduce it on develop like this:

% git diff                                   
diff --git a/docker-compose-dev.yml b/docker-compose-dev.yml
index 986c0a49f1..e8fc26f8c1 100644
--- a/docker-compose-dev.yml
+++ b/docker-compose-dev.yml
@@ -9,6 +9,9 @@ services:
     restart: on-failure
     user: payara
     environment:
+      LINUX_PASSWORD: "F13D2435-CB9C-4F25-931C-92467A957374"
+      PAYARA_ADMIN_PASSWORD: "F13D2435-CB9C-4F25-931C-92467A957374"
+      DOMAIN_PASSWORD: "F13D2435-CB9C-4F25-931C-92467A957374"
       DATAVERSE_DB_HOST: postgres
       DATAVERSE_DB_PASSWORD: secret
       DATAVERSE_DB_USER: ${DATAVERSE_DB_USER}

docker compose -f docker-compose-dev.yml up works the first time.

Then I ctrl-c to stop it.

Then I run docker compose -f docker-compose-dev.yml up again and get this error:

dev_dataverse         | passwd: Authentication token manipulation error
dev_dataverse         | passwd: password unchanged
dev_dataverse         | Changing password for payara.
dev_dataverse exited with code 10

[pdurbin]

passwd: Authentication token manipulation error

https://documentation.ubuntu.com/server/how-to/security/user-management/#minimum-password-length says, "By default, Ubuntu requires a minimum password length of 6 characters, as well as some basic entropy checks."

[poikilotherm]

Grml it worked on my machine. Might need to take another look and try to reproduce.

[ofahimIQSS]

Was able to reproduce the issue by following Phil's steps above.

Now I'll try out the fix.

[ofahimIQSS]

Fix looks good - no longer seeing the password errors. Merging.

[poikilotherm]

Thanks for merging @ofahimIQSS, much appreciated! 😄