XML Parsing Updates#11619
Merged
ofahimIQSS merged 15 commits intoIQSS:developfrom Jul 15, 2025
Merged
Conversation
Member
Author
|
After triggering two flaky test fails - see #11620 for one, the other is a ~timing deadlock trying to delete the dataset while the publishing onSuccess had yet to finish - this has passed all tests and should be ready for review. |
stevenwinship
moved this from Ready for Review ⏩
to In Review 🔎
in IQSS Dataverse Project
stevenwinship
approved these changes
Jul 10, 2025
github-project-automation
Bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
Contributor
|
cleared from my end - will do further regression testing on harvesting. |
github-project-automation
Bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
ubkm
added a commit
to DataverseNO/dataverse
that referenced
this pull request
Aug 21, 2025
ubkm
added a commit
to DataverseNO/dataverse
that referenced
this pull request
Aug 21, 2025
ubkm
added a commit
to DataverseNO/dataverse
that referenced
this pull request
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This PR centralizes creation of the various XML parsers used in Dataverse in a new util class and turns on recommended options.
Which issue(s) this PR closes:
Special notes for your reviewer: FWIW: For the XMLInputFactory class creation, the XMLInputFactory.IS_COALESCING flag was not consistently true in all uses in the code, but it I saw no code that would require it to be false and I'm guessing that the places it wasn't used, we weren't expecting CData sections.
I also caught/added a final close for some uses of the XMLStreamReader.
Suggestions on how to test this: Nominally this should not change parsing of our expected XML inputs. Aside from unit tests, we should assure that the changes don't break Harvesting (e.g. from DataCite) and ORCID linking/logging.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: