Improved Featured item efficiency during publication#11658
Merged
ofahimIQSS merged 5 commits intoIQSS:developfrom Sep 4, 2025
Merged
Improved Featured item efficiency during publication#11658ofahimIQSS merged 5 commits intoIQSS:developfrom
ofahimIQSS merged 5 commits intoIQSS:developfrom
Conversation
cmbz
added
FY26 Sprint 4
scolapasta
approved these changes
Sep 3, 2025
github-project-automation
Bot
moved this from Ready for Review ⏩
to Ready for QA ⏩
in IQSS Dataverse Project
Contributor
|
regression tested in internal - no issues found. Merging PR |
github-project-automation
Bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: The original code streamed through all files in the latest dataset version to create a list of all file ids, and did so once for each featured item, as a way to see if a datafile used in a FeaturedItem was in the latest version. This PR just checks that directly via df.isInDatasetVersion(), which should be more scalable.
Which issue(s) this PR closes:
Special notes for your reviewer: Just ran across this while hunting for an optimistic lock exception.
Suggestions on how to test this: Just regression test that publishing a dataset with FeaturedItems for some of its files deletes the items at publication time if the files are restricted in or deleted from the latest version.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: