fix facet and title display with ' in the value#11750
Merged
ofahimIQSS merged 3 commits intoIQSS:developfrom Sep 10, 2025
Merged
fix facet and title display with ' in the value#11750ofahimIQSS merged 3 commits intoIQSS:developfrom
ofahimIQSS merged 3 commits intoIQSS:developfrom
Conversation
ofahimIQSS
moved this from Ready for Triage
to Ready for Review ⏩
in IQSS Dataverse Project
sekmiller
reviewed
Aug 28, 2025
| } | ||
|
|
||
| public void setDisplayTitle(String displayCitation) { | ||
| this.displayCitation = displayTitle; |
Contributor
There was a problem hiding this comment.
do you mean to set the displayCitation with a method named setDisplayTitle?
sekmiller
approved these changes
Sep 4, 2025
Contributor
sekmiller
left a comment
sekmiller
left a comment
There was a problem hiding this comment.
Looks good. thanks for the update
github-project-automation
Bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
Contributor
|
Very nice, thanks for the fix. Merging |
github-project-automation
Bot
moved this from Ready for QA ⏩
to Merged 🚀
in IQSS Dataverse Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Indirectly apply
MarkupChecker.stripAllTagsto presented dataWhich issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
See #11737
After deploy re-index the datasets with the
'values to make the facets appear properly.Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
No
Additional documentation: