IQSS/11778 speedup custom file retrieval#11780
Merged
ofahimIQSS merged 2 commits intoIQSS:developfrom Sep 5, 2025
Merged
Conversation
ofahimIQSS
moved this from Ready for Triage
to Ready for Review ⏩
in IQSS Dataverse Project
stevenwinship
moved this from Ready for Review ⏩
to In Review 🔎
in IQSS Dataverse Project
stevenwinship
approved these changes
Sep 3, 2025
github-project-automation
Bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
Contributor
|
merging this, looks good from my end |
github-project-automation
Bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Stops using tika to determine the mime type for custom files - saving ~80ms per file access, which can occur for multiple files and for every page
Which issue(s) this PR closes:
Special notes for your reviewer: As noted in the issue, I'd expect using the extension is good enough when the files are supplied by an admin (as in this case). If we really want to use tika to inspect these files, we should cache the results.
Suggestions on how to test this: Not sure this is easy to test as there are other factors to page load speed. That said, adding a custom header, footer, analytics file, and logo might add enough delay (est 1/3 second) that you might see a difference in average load time. (At QDR, I added code to time the tika call and the FileUtil calls.)
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: No - the PR that changed this was post 6.7 so the slower pages shouldn't be deployed in production anywhere.
Additional documentation: