A workaround for the annoying "draft not found" after a successful completion of async. publishing#11947
Merged
stevenwinship merged 2 commits intodevelopfrom Nov 7, 2025
Conversation
Contributor
Author
|
(this is already in the HDV 6.8 prod. patch deployed) |
This comment has been minimized.
This comment has been minimized.
pdurbin
approved these changes
Nov 3, 2025
Contributor
|
Tested: |
Contributor
|
Tested reloading while the publish was taking place. Draft shows until publish finishes. Then published version shows. Nice! |
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This has been annoying users for years now (#8136 #7653 #8548... there are possibly more that I couldn't find right away). This 3-line workaround makes it less annoying.
Which issue(s) this PR closes:
It may be debatable whether it actually "closes" the issue below. I am selling it as a "workaround" only. But it definitely improves the user experience; and we likely don't want to invest any more effort than this into a jsf page at this point. So may as well close it.
Special notes for your reviewer:
Suggestions on how to test this:
Prior to this build: publish a dataset; when the async. publishing process completes in the background and the lock disappears, the url in the browser location bar will still have "version=DRAFT" in it. You may or may not see the yellow "draft not found, verison such and such shown instead" warning at this point. Try to reload the page - now you will be presented with the annoying yellow message. (Apparently that's what real life users keep doing: instead of manually removing the "version=" parameter from the url, they keep reloading the page, hoping that it will go away - and keep seeing the warning message again...)
With this build deployed: you should not be seeing the yellow warning message at any point during the publishing process. Reloading the page will quietly send you to the now published version. (Assuming publishing has actually worked; if it has failed for whatever reason, you will stay on your draft version, which is what we want)
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: