Skip to content

A workaround for the annoying "draft not found" after a successful completion of async. publishing#11947

Merged
stevenwinship merged 2 commits intodevelopfrom
8136-annoying-draft-message-after-publishing
Nov 7, 2025
Merged

A workaround for the annoying "draft not found" after a successful completion of async. publishing#11947
stevenwinship merged 2 commits intodevelopfrom
8136-annoying-draft-message-after-publishing

Conversation

@landreev
Copy link
Copy Markdown
Contributor

@landreev landreev commented Oct 31, 2025

What this PR does / why we need it:

This has been annoying users for years now (#8136 #7653 #8548... there are possibly more that I couldn't find right away). This 3-line workaround makes it less annoying.

Which issue(s) this PR closes:

It may be debatable whether it actually "closes" the issue below. I am selling it as a "workaround" only. But it definitely improves the user experience; and we likely don't want to invest any more effort than this into a jsf page at this point. So may as well close it.

Special notes for your reviewer:

Suggestions on how to test this:

Prior to this build: publish a dataset; when the async. publishing process completes in the background and the lock disappears, the url in the browser location bar will still have "version=DRAFT" in it. You may or may not see the yellow "draft not found, verison such and such shown instead" warning at this point. Try to reload the page - now you will be presented with the annoying yellow message. (Apparently that's what real life users keep doing: instead of manually removing the "version=" parameter from the url, they keep reloading the page, hoping that it will go away - and keep seeing the warning message again...)

With this build deployed: you should not be seeing the yellow warning message at any point during the publishing process. Reloading the page will quietly send you to the now published version. (Assuming publishing has actually worked; if it has failed for whatever reason, you will stay on your draft version, which is what we want)

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

…condition after the successful completion of async. publishing. #8136 #7653 #8548
@github-actions github-actions Bot added Component: JSF Involves modifying JSF (Jakarta Server Faces) code, which is being replaced with React. Type: Bug a defect User Role: Depositor Creates datasets, uploads data, etc. UX & UI: Design This issue needs input on the design of the UI and from the product owner labels Oct 31, 2025
@landreev
Copy link
Copy Markdown
Contributor Author

(this is already in the HDV 6.8 prod. patch deployed)

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 31, 2025

Coverage Status

coverage: 23.798% (-0.001%) from 23.799%
when pulling eed5e67 on 8136-annoying-draft-message-after-publishing
into c6ccf87 on develop.

@github-actions

This comment has been minimized.

@github-project-automation github-project-automation Bot moved this to Ready for QA ⏩ in IQSS Dataverse Project Nov 3, 2025
@landreev landreev changed the title A workaround for the annoying "draft not found" after the successful completion of async. publishing A workaround for the annoying "draft not found" after a successful completion of async. publishing Nov 3, 2025
@cmbz cmbz added the FY26 Sprint 9 FY26 Sprint 9 (2025-10-22 - 2025-11-05) label Nov 5, 2025
@cmbz cmbz added the FY26 Sprint 10 FY26 Sprint 10 (2025-11-05 - 2025-11-19) label Nov 5, 2025
@stevenwinship stevenwinship self-assigned this Nov 7, 2025
@stevenwinship stevenwinship moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Nov 7, 2025
@stevenwinship
Copy link
Copy Markdown
Contributor

stevenwinship commented Nov 7, 2025

Tested:
Original code did show DRAFT in url and yellow Draft not found message when reloading
New code brought up published version when reloading the url with version=DRAFT

@stevenwinship
Copy link
Copy Markdown
Contributor

Tested reloading while the publish was taking place. Draft shows until publish finishes. Then published version shows. Nice!

@stevenwinship stevenwinship merged commit c325662 into develop Nov 7, 2025
19 of 20 checks passed
@github-project-automation github-project-automation Bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Nov 7, 2025
@stevenwinship stevenwinship deleted the 8136-annoying-draft-message-after-publishing branch November 7, 2025 16:12
@stevenwinship stevenwinship removed their assignment Nov 7, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 7, 2025

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:8136-annoying-draft-message-after-publishing
ghcr.io/gdcc/configbaker:8136-annoying-draft-message-after-publishing

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@pdurbin pdurbin added this to the 6.9 milestone Nov 7, 2025
@scolapasta scolapasta moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: JSF Involves modifying JSF (Jakarta Server Faces) code, which is being replaced with React. FY26 Sprint 9 FY26 Sprint 9 (2025-10-22 - 2025-11-05) FY26 Sprint 10 FY26 Sprint 10 (2025-11-05 - 2025-11-19) Type: Bug a defect User Role: Depositor Creates datasets, uploads data, etc. UX & UI: Design This issue needs input on the design of the UI and from the product owner

Projects

Status: Done 🧹

6 participants