Skip to content

Fix signature of writeGuestbookAndStartFileDownload in xhtml#12252

Merged
landreev merged 2 commits intodevelopfrom
fix-download-with-guestbook
Mar 26, 2026
Merged

Fix signature of writeGuestbookAndStartFileDownload in xhtml#12252
landreev merged 2 commits intodevelopfrom
fix-download-with-guestbook

Conversation

@stevenwinship
Copy link
Copy Markdown
Contributor

@stevenwinship stevenwinship commented Mar 25, 2026

What this PR does / why we need it: Method signature changed causing xhtml to not find the method. See issue for details

Which issue(s) this PR closes:#12251

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?: Included

Additional documentation:

@stevenwinship stevenwinship moved this to In Progress 💻 in IQSS Dataverse Project Mar 25, 2026
@github-actions github-actions Bot added the Type: Bug a defect label Mar 25, 2026
@stevenwinship stevenwinship self-assigned this Mar 25, 2026
@stevenwinship stevenwinship added this to the 6.10 milestone Mar 25, 2026
@stevenwinship stevenwinship added the Size: 3 A percentage of a sprint. 2.1 hours. label Mar 25, 2026
@pdurbin pdurbin modified the milestones: 6.10, 6.11 Mar 25, 2026
@stevenwinship stevenwinship moved this from In Progress 💻 to Ready for Review ⏩ in IQSS Dataverse Project Mar 25, 2026
@stevenwinship stevenwinship removed their assignment Mar 25, 2026
@pdurbin pdurbin self-assigned this Mar 25, 2026
@pdurbin pdurbin moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Mar 25, 2026
actionListener="#{fileDownloadService.writeGuestbookAndStartFileDownload(guestbookResponse, fileMetadata, 'var')}">
actionListener="#{fileDownloadService.writeGuestbookAndStartFileDownload(guestbookResponse, fileMetadata, 'var', null)}">
#{bundle['file.downloadBtn.format.var']}
</p:commandLink>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just noting that https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-12252/2/consoleFull failed with something unrelated:

TASK [dataverse : Wait until localstack status is ready] ***********************
FAILED - RETRYING: [localhost]: Wait until localstack status is ready (18 retries left).
FAILED - RETRYING: [localhost]: Wait until localstack status is ready (17 retries left).
FAILED - RETRYING: [localhost]: Wait until localstack status is ready (16 retries left).
FAILED - RETRYING: [localhost]: Wait until localstack status is ready (15 retries left).
FAILED - RETRYING: [localhost]: Wait until localstack status is ready (14 retries left).
FAILED - RETRYING: [localhost]: Wait until localstack status is ready (13 retries left).
FAILED - RETRYING: [localhost]: Wait until localstack status is ready (12 retries left).
FAILED - RETRYING: [localhost]: Wait until localstack status is ready (11 retries left).
FAILED - RETRYING: [localhost]: Wait until localstack status is ready (10 retries left).
FAILED - RETRYING: [localhost]: Wait until localstack status is ready (9 retries left).
FAILED - RETRYING: [localhost]: Wait until localstack status is ready (8 retries left).
FAILED - RETRYING: [localhost]: Wait until localstack status is ready (7 retries left).
FAILED - RETRYING: [localhost]: Wait until localstack status is ready (6 retries left).
FAILED - RETRYING: [localhost]: Wait until localstack status is ready (5 retries left).
FAILED - RETRYING: [localhost]: Wait until localstack status is ready (4 retries left).
FAILED - RETRYING: [localhost]: Wait until localstack status is ready (3 retries left).
FAILED - RETRYING: [localhost]: Wait until localstack status is ready (2 retries left).
FAILED - RETRYING: [localhost]: Wait until localstack status is ready (1 retries left).
fatal: [localhost]: FAILED! => {"attempts": 18, "changed": false, "content": "", "elapsed": 0, "msg": "Status code was -1 and not [200]: Request failed: <urlopen error [Errno 111] Connection refused>", "redirected": false, "status": -1, "url": "http://localhost:4566/"}

I just kicked off https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-12252/3/

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problems on my laptop:

docker logs dev_localstack

LocalStack version: 4.2.0
LocalStack build date: 2025-02-27
LocalStack build git hash: 2144203e0

2026-03-25T17:24:02.119  WARN --- [  MainThread] localstack.deprecations    : HOSTNAME_EXTERNAL is deprecated (since 2.0.0) and will be removed in upcoming releases of LocalStack! This configuration will be migrated to LOCALSTACK_HOST
2026-03-25T17:24:06.981  INFO --- [et.reactor-0] localstack.request.aws     : AWS s3.CreateBucket => 200
make_bucket: mybucket
Ready.

🤷

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's working on my laptop, I created an issue on the ansible side:

Copy link
Copy Markdown
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing but seems unrelated to this PR. Details at #12252 (comment) and in Slack.

I tested this PR locally and this is definitely better than what we shipped in 6.10. I'm not sure if I'm hitting all use cases, but I'm approving this, at least.

@github-project-automation github-project-automation Bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Mar 25, 2026
@pdurbin pdurbin removed their assignment Mar 25, 2026
@pdurbin pdurbin modified the milestones: 6.11, 6.10.1 Mar 25, 2026
@landreev landreev moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Mar 26, 2026
@landreev landreev self-assigned this Mar 26, 2026
@landreev landreev merged commit 8406879 into develop Mar 26, 2026
6 of 7 checks passed
@github-project-automation github-project-automation Bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Mar 26, 2026
@pdurbin pdurbin mentioned this pull request Mar 26, 2026
@cmbz cmbz added the FY26 Sprint 20 FY26 Sprint 20 (2026-03-26 - 2026-04-08) label Mar 27, 2026
@scolapasta scolapasta moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Mar 31, 2026
@landreev landreev removed their assignment Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY26 Sprint 20 FY26 Sprint 20 (2026-03-26 - 2026-04-08) Size: 3 A percentage of a sprint. 2.1 hours. Type: Bug a defect

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

Cannot download files individually from Dataverse 6.10

5 participants