Fixed Anonymous guestbook file download via persistentId#12363
Open
stevenwinship wants to merge 6 commits intodevelopfrom
Open
Fixed Anonymous guestbook file download via persistentId#12363stevenwinship wants to merge 6 commits intodevelopfrom
stevenwinship wants to merge 6 commits intodevelopfrom
Conversation
|
coverage: 24.956% (-0.004%) from 24.96% — 12245-anon-guestbook-download-via-persistentid into develop |
This comment has been minimized.
This comment has been minimized.
stevenwinship
force-pushed
the
12245-anon-guestbook-download-via-persistentid
branch
from
04e5ba0 to
78793ff
Compare
This comment has been minimized.
This comment has been minimized.
stevenwinship
moved this from In Progress 💻
to Ready for Review ⏩
in IQSS Dataverse Project
landreev
reviewed
Apr 28, 2026
Contributor
landreev
left a comment
landreev
left a comment
There was a problem hiding this comment.
One quick request:
Could you please fix all the misspelled signature-secret in config.rst as well in the same pr.
landreev
reviewed
Apr 28, 2026
landreev
reviewed
Apr 28, 2026
stevenwinship
force-pushed
the
12245-anon-guestbook-download-via-persistentid
branch
from
dcbe01d to
f2544d4
Compare
This comment has been minimized.
This comment has been minimized.
4 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
landreev
approved these changes
Apr 30, 2026
Contributor
landreev
left a comment
landreev
left a comment
There was a problem hiding this comment.
I meant to wait for Jenkins run to finish and move it into "ready"... but forgot about it/got distracted.
github-project-automation
Bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
stevenwinship
force-pushed
the
12245-anon-guestbook-download-via-persistentid
branch
from
9f2b5b4 to
3ccee6e
Compare
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:Guest downloads using persistentId were not working When guestbook responses were given.
Which issue(s) this PR closes:#12245
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: Included
Additional documentation: