Open
Conversation
This comment has been minimized.
This comment has been minimized.
…taverse into 12174-file-level-handles
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
pdurbin
approved these changes
Apr 29, 2026
Member
pdurbin
left a comment
There was a problem hiding this comment.
I didn't test this but the change makes sense. Approved!
| datasetUrl.getBytes(), | ||
| HandleValue.TTL_TYPE_RELATIVE, 86400, | ||
| timestamp, null, true, true, true, false)}; | ||
| timestamp, null, true, true, false, false)}; |
Member
There was a problem hiding this comment.
Looks fine but I'm just leaving a comment so we can easily see that "publicRead" is what's being changed:
this.timestamp = timestamp;
this.references = references;
this.adminRead = adminRead;
this.adminWrite = adminWrite;
this.publicRead = publicRead;
this.publicWrite = publicWrite;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Unplanned, and somewhat low effort PR in response to a problem report from a community member. Once I started looking into it, I realized the fix would be trivial, and that a much older issue opened by the same user could be fixed similarly for cheap.
See the release note for the summary of the fixes.
Which issue(s) this PR closes:
Special notes for your reviewer:
I tried to rebase the branch and squash the 3 commits into one. But for whatever reason the first 3 commits are still showing individually. 🤷
Suggestions on how to test this:
See the release note for the summary of the fixes.
The dev. team maintains a fully-functional handles instance with its own name space (
hdl:20.500.12050) which should be used for testing anything handles-related.This can be done on:
testhandlesconfigured that uses the name space above.Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: