Conversation
jurikane
left a comment
jurikane
left a comment
There was a problem hiding this comment.
Reviewed overall and left two non-blocking inline comments/questions; otherwise looks good to me.
| # step 3: write json file | ||
| write_json(output_path, tree_json) | ||
| # write tree as json | ||
| write_json(output_path, tree) |
There was a problem hiding this comment.
Is it on purpose to still write it as JSON now that the files are .yaml ?
There was a problem hiding this comment.
Yes, the output is always in JSON to be easily consumable by tools. We switched the input to yaml one or two years ago to make editing simpler.
| make dev # like make, but lining the front-end assets for development | ||
|
|
||
| make serve # starts a http server on port :8000 so that you can access the protocol in your browser | ||
| make app |
There was a problem hiding this comment.
maybe we can add a short troubleshooting note for branch switches or dependency changes,
I hit a build failure until I removed node_modules and reran npm ci.
Something like:
make cleannode && make app
There was a problem hiding this comment.
Yes, I changed the Makefile to run npm ci on each npm call and added some information about the clean targets to README.md.
| make watch # automatically rebuild when the source changes | ||
| ``` | ||
|
|
||
| When working with different branches or after dependency changed, it the following make targets can be used to clean the local copy: |
There was a problem hiding this comment.
"dependency changed, it the"
to
"dependency changes, the"
3 participants
This PR aims to refactor the protocol to make it better maintainable. In particular:
app/Makefileand move JavaScript config into the root of the repo.assets.pybuild script and only useviteto build the (web) app.README.md.buildscripts to usePath.rglobinstead ofos.walkand add logging..pre-commit-config.yamland apply ruff-format and eslint rules.treefiles toyaml.schemafiles.pattern,schema, andtreefiles.Draft version: https://draft.isimip.org/protocol/dev/.