feat: Add support for Unknown recipient for My ksuite instead of external#2818
Open
benjaminVadon wants to merge 8 commits intomainfrom
Open
feat: Add support for Unknown recipient for My ksuite instead of external#2818benjaminVadon wants to merge 8 commits intomainfrom
benjaminVadon wants to merge 8 commits intomainfrom
Conversation
benjaminVadon
force-pushed
the
myKsuite-external
branch
from
c7bf37e to
5e05ac3
Compare
|
FabianDevel
force-pushed
the
myKsuite-external
branch
from
5e05ac3 to
7da0af6
Compare
|
Failed to generate code suggestions for PR |
FabianDevel
requested changes
Mar 30, 2026
Contributor
FabianDevel
left a comment
FabianDevel
left a comment
There was a problem hiding this comment.
You're missing the translation of the banner in the newMessageActivity
Also, maybe the description should change to avoid talking about organization ?
| --> | ||
| <resources> | ||
| <string name="appName" translatable="false">Infomaniak Mail</string> | ||
|
|
app/src/main/java/com/infomaniak/mail/data/models/mailbox/Mailbox.kt
Outdated
Show resolved
Hide resolved
… and tag for external or unknown
benjaminVadon
force-pushed
the
myKsuite-external
branch
from
7da0af6 to
5e2d5be
Compare
PR Reviewer Guide 🔍(Review updated until commit 6279291)Here are some key observations to aid the review process:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
app/src/main/java/com/infomaniak/mail/ui/main/thread/SubjectFormatter.kt
Show resolved
Hide resolved
|
Persistent review updated to latest commit 6279291 |
PR Code Suggestions ✨No code suggestions found for the PR. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.