feat: Messages actions use case by solrubado · Pull Request #2819 · Infomaniak/android-kMail

solrubado · 2026-02-23T15:24:36Z

Depends on #2814

github-actions · 2026-03-03T15:23:05Z

This PR/issue depends on:

~~refactor: Network management #2814~~
By Dependent Issues (🤖). Happy coding!

app/src/main/java/com/infomaniak/mail/ui/main/thread/actions/ActionsViewModel.kt

app/src/main/java/com/infomaniak/mail/useCases/MessagesActionsUseCase.kt

FabianDevel · 2026-03-04T10:15:16Z

app/src/main/java/com/infomaniak/mail/useCases/MessagesActionsUseCase.kt

+    }
+
+    sealed class ApiCallResult {
+        data class Success(val messageRes: Int) : ApiCallResult()


Why did you put a message in success ? I don't think we need it

We show a success message when we do a phishing report, block user and when we successfully undo an action.

app/src/main/java/com/infomaniak/mail/useCases/MessagesActionsUseCase.kt

app/src/main/java/com/infomaniak/mail/ui/main/thread/actions/ActionsViewModel.kt

FabianDevel · 2026-03-04T10:46:38Z

app/src/main/java/com/infomaniak/mail/ui/main/thread/actions/ActionsViewModel.kt

-
-    private suspend fun moveOutThreadsLocally(messages: List<Message>, destinationFolder: Folder): List<String> {
-        val uidsToMove = mutableListOf<String>().apply {
-            messages.flatMapTo(mutableSetOf(), Message::threads).forEach { thread ->


I see that you now open the realm to get the thread, why do you need to do it now ?

It is safer this way, the old code could access thread.messages and it.folderId on potentially deleted objects.

app/src/main/java/com/infomaniak/mail/ui/MainViewModel.kt

app/src/main/java/com/infomaniak/mail/useCases/MessagesActionsUseCase.kt

…atus manager

…unctionm

FabianDevel

It appears when testing that the messages actions inside a thread may not work

FabianDevel · 2026-03-27T12:53:58Z

app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadFragment.kt

                    trackScheduleSendEvent(MatomoName.CustomScheduleConfirm)
                    localSettings.lastSelectedScheduleEpochMillis = timestamp
-                    mainViewModel.rescheduleDraft(Date(timestamp))
+                    actionsViewModel.rescheduleDraft(Date(timestamp), mainViewModel.currentMailbox.value!!)


You should not add new code with this nullablility check
You can manage it like elsewhere with an error snackback

FabianDevel · 2026-03-27T13:22:47Z

app/src/main/java/com/infomaniak/mail/ui/MainViewModel.kt

+                threadController.updateIsLocallyMovedOutStatus(threadsUids, hasBeenMovedOut = false)
+            }
        }
+


Revert this

FabianDevel · 2026-03-27T13:26:01Z

app/src/main/java/com/infomaniak/mail/ui/MainViewModel.kt

+        downloadThreadsStatusManager.updateState(false)
    }

+


Revert this

FabianDevel · 2026-03-27T13:42:51Z

app/src/main/java/com/infomaniak/mail/useCases/MessagesActionsUseCase.kt

+            threads.flatMap { thread ->
+                messageController.getLastMessageAndItsDuplicatesToExecuteAction(thread, mailbox.featureFlags)
+            }
+        } else threads.flatMap { thread -> messageController.getUnseenMessages(thread) }


Always add the brackets when the whole if cannot be inlined

FabianDevel · 2026-03-27T13:44:06Z

app/src/main/java/com/infomaniak/mail/useCases/MessagesActionsUseCase.kt

+                messages = messages,
+                mailbox = mailbox,
+                threadsUids = threadsUids,
+            )


oneline this

FabianDevel · 2026-03-27T14:13:32Z

app/src/main/java/com/infomaniak/mail/utils/DownloadThreadsStatusManager.kt

+    fun updateState(isDownloading: Boolean) {
+        _isDownloading.value = isDownloading
+    }
+


Remove this line

FabianDevel · 2026-03-27T15:08:04Z

app/src/main/java/com/infomaniak/mail/ui/main/SnackbarManager.kt


    data class UndoData(
-        val resources: List<String>,
+        val resources: List<String>?,


It doesn't need to be nullable, and the code that checks this nullability will be useless

…box with unsafe null operator

…ction Since it will be just one message, filtering is not needed, filter is just for thread actions

sonarqubecloud · 2026-04-02T12:12:36Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions bot assigned solrubado Feb 23, 2026

solrubado changed the title ~~Messages actions use case~~ feat: Messages actions use case Feb 24, 2026

github-actions bot added the dependent This MR depends on another PR label Feb 24, 2026

FabianDevel force-pushed the network-management branch from 8a8e99a to 73350ef Compare March 3, 2026 14:34

FabianDevel force-pushed the messages-actions-use-case branch from b80a46a to 3a7ff5e Compare March 3, 2026 14:34

solrubado force-pushed the network-management branch from e6d2918 to cde5dde Compare March 3, 2026 15:11

Base automatically changed from network-management to protected/refactor-mail-actions March 3, 2026 15:22

github-actions bot removed the dependent This MR depends on another PR label Mar 3, 2026

solrubado added 15 commits March 3, 2026 16:23

fix: Improve network manager coroutine scope

e77eb2c

refactor: Add move, spam and delete use cases

49b2305

refactor: Add seen actions to messagesActionsUseCase

3492562

refactor: Add toggle favorite to messagesActionsUseCase

ffbccae

refactor: Add phishing and block user to messagesActionsUseCase

17fab05

refactor: Add snooze and undo actions to messageActionsUseCase

49d0dfc

refactor: Remove messages related functions from SharedUtils

009626a

refactor: Remove duplicated move code in MainViewModel

b2c7638

refactor: Remove unnecesary comments, check unsafe calls

5a18fcf

refactor: Add missing commas

0478e12

fix: Fix ai suggestions

2a4baf2

fix: Fix suggested changes by AI

8a40bce

fix: Fix PR

b395c2c

refactor: Add missing commas

0a99ae3

fix: Fix sonar issues

3db2f00

solrubado force-pushed the messages-actions-use-case branch from 3a7ff5e to 3db2f00 Compare March 3, 2026 15:26

FabianDevel requested changes Mar 4, 2026

View reviewed changes

solrubado added 4 commits March 18, 2026 16:41

fix: Fix PR review comments

0a1f00a

fix: Fix functions names to be consistent

b36cfa5

fix: Commit missing changes on functions names

39441d3

refactor: Change refresh folders function to MessagesActionsUseCase

67a2d28

solrubado added 10 commits March 19, 2026 10:54

refactor: Move draft actions to ActionsViewModel and use refreshAsync

9591e05

fix: Remove unused undo data on permanently delete

97f9a79

fix: Put refresh threads in viewModels and create download threads st…

3e143a1

…atus manager

fix: Remove unused functions and give threadsuids to ondownloadstop f…

5520710

…unctionm

fix: Toggle unseen and move to new folder and changes for PR

f54817d

fix: Fix long line

db72289

refactor: Remove duplicated code in viewmodels

5c968b1

fix: Fix Sonar issues

9bb1111

fix: Add snackbar when move result is null

42f5ef0

refactor: Add new lines after early return

9c6dbcf

solrubado force-pushed the messages-actions-use-case branch from e18fa08 to 9c6dbcf Compare March 23, 2026 14:11

refactor: Remove unnecessary functions for getting messages to favorite

a490122

FabianDevel requested changes Mar 27, 2026

View reviewed changes

solrubado added 3 commits April 1, 2026 17:06

fix: Undo Data doesn't require nullable resources and don't send mail…

460b4b8

…box with unsafe null operator

fix: Don't filter messages before action if it comes from a message a…

5eae427

…ction Since it will be just one message, filtering is not needed, filter is just for thread actions

fix: Fix block sender functionality

6a03b28

Conversation

solrubado commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

FabianDevel left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Apr 2, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

solrubado commented Feb 23, 2026 •

edited

Loading