Skip to content

fix: Remove translators from web-ext ignore #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tobiasdiez merged 2 commits into from
Apr 1, 2026
Merged

fix: Remove translators from web-ext ignore #639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
610a20a
Remove translators from web-ext ignore
LyzardKing Mar 25, 2026
d114c0f
Fix linter / translator imports by updating translators to a version …
tobiasdiez Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/import_and_patch_translators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ def append_exports(text: str) -> tuple[str, bool]:

def ensure_sandbox_import(text: str) -> tuple[str, bool]:
import_re = re.compile(
r"^\s*import\s*\{\s*([^}]*)\}\s*from\s*[\"']\.\./\.\./sources/sandbox\.js[\"'];?\s*$",
r"^\s*import\s*\{\s*([^}]*)\}\s*from\s*[\"'].*sandbox\.js[\"'];?\s*$",
re.MULTILINE,
)
match = import_re.search(text)
Expand Down
15 changes: 1 addition & 14 deletions translators/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2518,19 +2518,6 @@
"minVersion": "3.0",
"maxVersion": ""
},
{
"path": "translators/zotero/Edinburgh University Press Journals.js",
"label": "Edinburgh University Press Journals",
"translatorID": "b7bd798d-e518-46d1-aa13-a69f2864fa91",
"target": "^https?://www\\.euppublishing\\.com/",
"browserSupport": "gcsibv",
"translatorType": 4,
"creator": "Sebastian Karcher",
"priority": 100,
"lastUpdated": "2016-09-13 21:55:09",
"minVersion": "3.0",
"maxVersion": ""
},
{
"path": "translators/zotero/Education Week.js",
"label": "Education Week",
Expand Down Expand Up @@ -7379,7 +7366,7 @@
"translatorType": 4,
"creator": "Michael Berkowitz and Aurimas Vinckevicius",
"priority": 100,
"lastUpdated": "2025-12-02 18:01:21",
"lastUpdated": "2026-03-19 20:29:30",
"minVersion": "3.0",
"maxVersion": ""
},
Expand Down
2 changes: 1 addition & 1 deletion translators/zotero
Open in desktop
Submodule zotero updated 713 files
1 change: 0 additions & 1 deletion web-ext-config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ export default {
"circle.yml",
"package-lock.json",
"install_linux.sh",
"translators",
".idea",
"workspace.code-workspace",
"test.js",
Expand Down
Loading
⚡