vertical render added and autoplay option added#266
vertical render added and autoplay option added#266poojan010 wants to merge 4 commits intoJacse:masterfrom
Conversation
|
i have implemented the changes you requested |
|
Hi @poojan010 there are a few unresolved comments / questions. Could you also add something to the documentation (maybe include a screenshot as well)? |
|
Hi @Jacse I have Fixed unresolved comments / questions and even added screenshots to docs I have used background colours for slides because i did not have images that you used to generate screenshots for basic example |
|
@Jacse ^^ |
|
Hi again @poojan010 thanks for the persistence. I'm really sorry to tell you this now, but seeing it I don't think vertical rendering is something we should support. I have a hard time thinking that this is often useful (but I could be wrong). The autoplay I will gladly merge, though. |
|
Do you think changing skip and next button UI will make vertical render better ? |
2 participants
I have added vertical render functionality so now swipe up and down can also be possible
also added new prop autoPlay which will be used to scroll slides automatically
Indentation is modified with 2 spaces