This repository was archived by the owner on May 2, 2025. It is now read-only.
timeline: remove unnecessary dependencies for timeline v3#64
Merged
Conversation
c-dilks
force-pushed
the
timeline-v3-deps
branch
from
647bba6 to
9f89caf
Compare
JeffersonLab/clas12-timeline#293 removes the explicit need for `groovy` and `coatjava` as external dependencies; the Maven build will just copy the necessary JAR files for these, so now the timeline code is much more standalone. RCDB remains as an external dependency. See the PR for reasoning and details. This should not be merged until we have actually deployed v3.
c-dilks
force-pushed
the
timeline-v3-deps
branch
from
9f89caf to
29b6372
Compare
baltzell
approved these changes
Apr 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JeffersonLab/clas12-timeline#293 removes the explicit need for
groovyandcoatjavaas external dependencies; the Maven build will just copy the necessary JAR files for these, so now the timeline code is much more standalone. RCDB remains as an external dependency. See the PR for reasoning and details.This should not be merged until we have actually deployed v3.ready now