`IllegalArgumentException: min == max` in `ALERTFitter.tdcfitter`

[c-dilks]

We're seeing a lot of these from Step 2:

java.lang.IllegalArgumentException: min == max                                        
        at org.freehep.math.minuit.MinuitParameter.setLimits(MinuitParameter.java:92)                                                                                          
        at org.freehep.math.minuit.MnUserTransformation.setLimits(MnUserTransformation.java:182)                                                                               
        at org.freehep.math.minuit.MnUserTransformation.setLimits(MnUserTransformation.java:225)                                                                               
        at org.freehep.math.minuit.MnUserParameters.setLimits(MnUserParameters.java:181)                                                                                       
        at org.jlab.groot.fitter.DataFitter.fit(DataFitter.java:66)                                                                                                            
        at org.codehaus.groovy.vmplugin.v8.IndyInterface.fromCache(IndyInterface.java:321)         
        at org.jlab.clas.timeline.fitter.ALERTFitter.tdcfitter(ALERTFitter.groovy:32)                                                                                          
        at org.codehaus.groovy.vmplugin.v8.IndyInterface.fromCache(IndyInterface.java:321)                                                                                     
        at org.jlab.clas.timeline.analysis.alert_atof_tdc$_processRun_closure1.doCall(alert_atof_tdc.groovy:26)                                                                
        at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
        at java.base/java.lang.reflect.Method.invoke(Method.java:580)                                                                                                          
        at org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:343)                                                                                           
        at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:328)                                                                                                          
        at org.codehaus.groovy.runtime.metaclass.ClosureMetaClass.invokeMethod(ClosureMetaClass.java:280)                                                                      
        at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1007)                                                                                                     
        at groovy.lang.Closure.call(Closure.java:433)                               
        at groovy.lang.Closure.call(Closure.java:422)                
        at org.codehaus.groovy.runtime.DefaultGroovyMethods.collect(DefaultGroovyMethods.java:3661)                                                                            
        at org.codehaus.groovy.runtime.DefaultGroovyMethods.collect(DefaultGroovyMethods.java:3646)
        at org.codehaus.groovy.runtime.DefaultGroovyMethods.collect(DefaultGroovyMethods.java:3692)
        at org.codehaus.groovy.runtime.dgm$103.doMethodInvoke(Unknown Source)                                                                                                  
        at org.codehaus.groovy.vmplugin.v8.IndyInterface.fromCache(IndyInterface.java:321)                                                                                     
        at org.jlab.clas.timeline.analysis.alert_atof_tdc.processRun(alert_atof_tdc.groovy:17)  
        at org.codehaus.groovy.vmplugin.v8.IndyInterface.fromCache(IndyInterface.java:321)      
        at org.jlab.clas.timeline.analysis.run_analysis$_run_closure6.doCall(run_analysis.groovy:166)
        at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
        at java.base/java.lang.reflect.Method.invoke(Method.java:580)                                                                                                          
        at org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:343)                                                                                           
        at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:328)               
        at org.codehaus.groovy.runtime.metaclass.ClosureMetaClass.invokeMethod(ClosureMetaClass.java:280)                                                                      
        at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1007)                                                                                                     
        at groovy.lang.Closure.call(Closure.java:433)                       
        at groovy.lang.Closure.call(Closure.java:422)                     
        at org.codehaus.groovy.runtime.DefaultGroovyMethods.each(DefaultGroovyMethods.java:2394)                                                                               
        at org.codehaus.groovy.runtime.DefaultGroovyMethods.each(DefaultGroovyMethods.java:2379)
        at org.codehaus.groovy.runtime.DefaultGroovyMethods.each(DefaultGroovyMethods.java:2420)
        at org.codehaus.groovy.runtime.dgm$207.doMethodInvoke(Unknown Source)                                                                                                  
        at org.codehaus.groovy.vmplugin.v8.IndyInterface.fromCache(IndyInterface.java:321)                                                                                     
        at org.jlab.clas.timeline.analysis.run_analysis.run(run_analysis.groovy:154)
        at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
        at java.base/java.lang.reflect.Method.invoke(Method.java:580)
        at org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:343)
        at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:328)
        at groovy.lang.MetaClassImpl.doInvokeMethod(MetaClassImpl.java:1333)
        at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1088)
        at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1007)
        at org.codehaus.groovy.runtime.InvokerHelper.invokePogoMethod(InvokerHelper.java:645)
        at org.codehaus.groovy.runtime.InvokerHelper.invokeMethod(InvokerHelper.java:628)
        at org.codehaus.groovy.runtime.InvokerHelper.runScript(InvokerHelper.java:422)
        at org.codehaus.groovy.vmplugin.v8.IndyInterface.fromCache(IndyInterface.java:321)
        at org.jlab.clas.timeline.analysis.run_analysis.main(run_analysis.groovy)

[c-dilks]

These errors also show up in the CI logs, e.g. most recent run on main: https://github.com/JeffersonLab/clas12-timeline/actions/runs/14602432081/job/40964216123#step:8:2826

[Sangbaek]

I suspect this is from that the ALERT banks are empty for the other run groups and after #305, this will be fixed simultaneously.

@c-dilks , Do you want to publish a new module soon? I am working on the PAC proposal now, and I can work on this early next week.

[c-dilks]

This is also happening on RG-L data (though indeed, the CI does not check RG-L data).

[Sangbaek]

There is an issue with auto pass0 that the ATOF::tdc bank is not included. It works totally fine with decoded data.

[c-dilks]

Ah, okay that makes sense. I was just testing a workaround for this error and was wondering why the timelines were empty.

[Sangbaek]

Good. For the moment, I'm producing the ALERT timeline manually, with a coordination with the chef (and simultaneously my office-mate). But it'd be nicer to include the ALERT timeline in the qtl and module after everything gets stable.

for run in 21311 21313 21317 21339 21340 21342 21344 21345 21346 21347 21386 21387 21388 21391 21392 21394 21395 21399 21400 21401 21402 21403 21404 21422 21423 21424 21425 21426 21427 21428 21429 21430 21432 21433 21434 21435
do
java $TIMELINE_JAVA_OPTS org.jlab.clas.timeline.histograms.run_histograms $run runs/${run}/ lists/${run}.list 1000000 2.24
done

java $TIMELINE_JAVA_OPTS $run_analysis_script  alert_atof_tdc /volatile/clas12/sangbaek/clas12-timeline-alert-dev/runs/

where the ${run}.list files contain the /volatile/clas12/rg-l/production/1passbeam/dst_with_atof/recon/0${run}/ .

[c-dilks]

I'm planning to tag v3 today and deploy it, which will include these ALERT timelines; I have some more testing of #301 to do though, so I might as well try to include a fix for this issue.

[c-dilks]

Fixed in #308, let me know if you're okay with this.