Conversation
|
Looks good to me, thanks! I do have a review comment however: this PR nearly doubles the number of timelines; do you really need so many, or can you combine them? |
|
Thank you, Chris. Yes, I anticipate that the scroll in the clas12mon's alert web page will be super busy. I think you might want include the options to suppress the ALERT for other run groups except for RG-L. when you publish the new module with this update. I haven't heard from Raphael about the AHDC input yet, and I didn't include anything for the AHDC. |
|
Related issue: #305 |
|
Sounds good, thanks! It looks like the default behavior when ALERT data are not available is to fill ALERT timelines with flat zero, which is the current convention for other detectors, so that's not a problem for other run groups. Eventually we can add the ability to just not publish irrelevant timelines (you're welcome to send a PR on that if you can think of a general way to do it!) |
This PR consists of three major commits and two minor fixes for the ALERT timeline.
These are all prelim in sense that it only produces the ATOF TDC peak location/ sigma/ integral (normalized to the trigger.)
It is timeliy to include in the main branch to get the feedbacks from the ALERT experts.
runnum.hiponormalized integralby changing it fromintegral_per_triggertointegral_normalized_to_trigger