Conversation
Collaborator
Result:
|
Collaborator
Sangbaek
requested changes
Apr 7, 2026
Collaborator
Sangbaek
left a comment
There was a problem hiding this comment.
Some histograms have too small statistics and can't pass the minimum statistics condition.
Even if the condition is relaxed, it won't be able to be fitted with the existing fitter.
… to be range dynamic
Collaborator
Author
|
I made some change:
|
Collaborator
|
The biggest problem of the last review is that the reviewer (@Sangbaek) ran the timeline code on the pass0v8. It should've been pass0v9. Thanks to the patience of developers, I re-ran the test on the v9. Time now indeed has a gaussian peak. I'm not sure about z.
It's good to go. |
Sangbaek
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This is to include more QA checks on detector performance:
We add the following registered ALERT engines and histograms:
Here c4 means looking at the hits that coincide a wedge hit on the central ATOF (component 4).