Skip to content

feat: update include ATOF bar z#460

Merged
Sangbaek merged 2 commits intomainfrom
atof-add-zhist
Apr 7, 2026
Merged

feat: update include ATOF bar z#460
Sangbaek merged 2 commits intomainfrom
atof-add-zhist

Conversation

@zhiwanxu
Copy link
Copy Markdown
Collaborator

@zhiwanxu zhiwanxu commented Apr 6, 2026

This is to include more QA checks on detector performance:

  • ATOF z,
  • ATOF time separately per Sector, Layer

We add the following registered ALERT engines and histograms:

  • alert_atof_time_sl (s,l) ; 60 instances ; alert_atof_time_sl_{peak_location,sigma}_sector{S}_layer{L}.hipo ; 120 web items for mean and sigma
  • alert_atof_z ; 1 instance ; alert_atof_z_rms.hipo ; 1 web item for z RMS
  • alert_atof_z_sl (s,l) ; 60 instances ; alert_atof_z_sl_rms_sector{S}_layer{L}.hipo ; 60 web items for z RMS
  • alert_atof_z_c4 ; 1 instance ; alert_atof_z_c4_{peak_location,sigma}.hipo ; 2 web items for mean and sigma
  • alert_atof_z_c4_sl (s,l) ; 60 instances ; alert_atof_z_c4_sl_{peak_location,sigma}_sector{S}_layer{L}.hipo ; 120 web items for mean and sigma

Here c4 means looking at the hits that coincide a wedge hit on the central ATOF (component 4).

@zhiwanxu zhiwanxu marked this pull request as ready for review April 6, 2026 20:25
@zhiwanxu zhiwanxu requested review from Sangbaek and c-dilks April 6, 2026 20:25
@Sangbaek
Copy link
Copy Markdown
Collaborator

Sangbaek commented Apr 7, 2026

  1. major
    Test failed. Did you try this change in the ifarm?
cd /volatile/clas12/sangbaek/
git clone git@github.com:JeffersonLab/clas12-timeline.git
git clone git@github.com:JeffersonLab/clas12-timeline.git clas12-timeline-pr460
cd clas12-timeline-pr460
git fetch origin pull/460/head:pr460
git checkout pr460
mvn clean package
mkdir test_hipo
cd test_hipo/
ln -s /work/clas12b/rg-l/p0v8/mon/recon/022289 .
./bin/qtl-histogram -d test_pr460 --rundir test_hipo
./slurm/scripts/detectors.test_pr460.22289.sh
./bin/qtl-analysis -d test_pr460 --just-ana

Result:

/lustre24/expphy/volatile/clas12/sangbaek/clas12-timeline-pr460/outfiles/test_pr460/log/alert_atof_time_sl_sector00_layer0.err:WARNING: no data for this timeline, not producing
/lustre24/expphy/volatile/clas12/sangbaek/clas12-timeline-pr460/outfiles/test_pr460/log/alert_atof_time_sl_sector00_layer1.err:WARNING: no data for this timeline, not producing
/lustre24/expphy/volatile/clas12/sangbaek/clas12-timeline-pr460/outfiles/test_pr460/log/alert_atof_time_sl_sector00_layer2.err:WARNING: no data for this timeline, not producing
/lustre24/expphy/volatile/clas12/sangbaek/clas12-timeline-pr460/outfiles/test_pr460/log/alert_atof_time_sl_sector00_layer3.err:WARNING: no data for this timeline, not producing
/lustre24/expphy/volatile/clas12/sangbaek/clas12-timeline-pr460/outfiles/test_pr460/log/alert_atof_time_sl_sector01_layer0.err:WARNING: no data for this timeline, not producing
/lustre24/expphy/volatile/clas12/sangbaek/clas12-timeline-pr460/outfiles/test_pr460/log/alert_atof_time_sl_sector01_layer1.err:WARNING: no data for this timeline, not producing
(...)
/lustre24/expphy/volatile/clas12/sangbaek/clas12-timeline-pr460/outfiles/test_pr460/log/alert_atof_z_c4_sl_sector00_layer0.err:WARNING: no data for this timeline, not producing
/lustre24/expphy/volatile/clas12/sangbaek/clas12-timeline-pr460/outfiles/test_pr460/log/alert_atof_z_c4_sl_sector00_layer1.err:WARNING: no data for this timeline, not producing
/lustre24/expphy/volatile/clas12/sangbaek/clas12-timeline-pr460/outfiles/test_pr460/log/alert_atof_z_c4_sl_sector00_layer2.err:WARNING: no data for this timeline, not producing
/lustre24/expphy/volatile/clas12/sangbaek/clas12-timeline-pr460/outfiles/test_pr460/log/alert_atof_z_c4_sl_sector00_layer3.err:WARNING: no data for this timeline, not producing
/lustre24/expphy/volatile/clas12/sangbaek/clas12-timeline-pr460/outfiles/test_pr460/log/alert_atof_z_c4_sl_sector01_layer0.err:WARNING: no data for this timeline, not producing
/lustre24/expphy/volatile/clas12/sangbaek/clas12-timeline-pr460/outfiles/test_pr460/log/alert_atof_z_c4_sl_sector01_layer1.err:WARNING: no data for this timeline, not producing
(...)
  1. minor
    There are too many histograms for the same quantities, defined for different levels.
    Of course, there is no strict rule about defining histograms at a certain level, but I feel like it's too frequent to be nuanced.
    There is similar case in FT.java so I wouldn't request change for ALERT.java for now.
    I will work on this in June.

@Sangbaek
Copy link
Copy Markdown
Collaborator

Sangbaek commented Apr 7, 2026

This is what ATOF_Time_sector00_layer00_component00 looks like. It won't be fitted with Gaussian.

Screen Shot 2026-04-06 at 8 08 29 PM

Copy link
Copy Markdown
Collaborator

@Sangbaek Sangbaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some histograms have too small statistics and can't pass the minimum statistics condition.

Even if the condition is relaxed, it won't be able to be fitted with the existing fitter.

Comment thread src/main/java/org/jlab/clas/timeline/analysis/alert/alert_atof_time_sl.groovy Outdated
Comment thread src/main/java/org/jlab/clas/timeline/analysis/alert/alert_atof_z_c4_sl.groovy Outdated
Comment thread src/main/java/org/jlab/clas/timeline/analysis/alert/alert_atof_z_sl.groovy Outdated
@zhiwanxu
Copy link
Copy Markdown
Collaborator Author

zhiwanxu commented Apr 7, 2026

I made some change:

  • loose all the conditions that requires entries > 300 to entries > 10.
  • loose the conditions that require max > 30 to max > 3
  • change the ALERTFitter.atof_time_fitter(), the fitting range is now dynamic based on the histogram range, this allows us to easily change the histogram setting when doing the check on an old timeline, without need to modify the fitter again.

@Sangbaek Sangbaek added the rg-l PR for Run Group L label Apr 7, 2026
@Sangbaek
Copy link
Copy Markdown
Collaborator

Sangbaek commented Apr 7, 2026

The biggest problem of the last review is that the reviewer (@Sangbaek) ran the timeline code on the pass0v8. It should've been pass0v9. Thanks to the patience of developers, I re-ran the test on the v9. Time now indeed has a gaussian peak. I'm not sure about z.

Screen Shot 2026-04-07 at 12 28 01 PM Screen Shot 2026-04-07 at 12 37 26 PM
cd /volatile/clas12/sangbaek/
git clone git@github.com:JeffersonLab/clas12-timeline.git clas12-timeline-pr460
cd clas12-timeline-pr460
git fetch origin pull/460/head:pr460
git checkout pr460
mvn clean package
mkdir test_hipo
cd test_hipo/
ln -s /volatile/clas12/rg-l/production/p0v9/mon/recon/022829/ .
./bin/qtl-histogram -d test_pr460 --rundir test_hipo
./slurm/scripts/detectors.test_pr460.22829.sh
./bin/qtl-analysis -d test_pr460 --custom-pub -p ./test_pr460 --overwrite
  ================================================================
  OUTPUT AND ERROR LOGS:
  /lustre24/expphy/volatile/clas12/sangbaek/clas12-timeline-pr460/outfiles/test_pr460/log/*.out
  /lustre24/expphy/volatile/clas12/sangbaek/clas12-timeline-pr460/outfiles/test_pr460/log/*.err

All jobs exitted normally
Now scanning for any quieter errors, by running `grep -iE 'error:|exception:|warning'` on *.err files:
================================================================

It's good to go.

Copy link
Copy Markdown
Collaborator

@Sangbaek Sangbaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes were made accordingly.
It was just the reviewer's mistake that looked at the previous version.
But, I think relaxing the condition is a good idea in general.

@Sangbaek Sangbaek changed the title update include ATOF bar z feat: update include ATOF bar z Apr 7, 2026
@Sangbaek Sangbaek merged commit f1a56e1 into main Apr 7, 2026
9 checks passed
@Sangbaek Sangbaek deleted the atof-add-zhist branch April 7, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rg-l PR for Run Group L

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants