Skip to content

feat: update ATOF z histogram fitting range#463

Merged
Sangbaek merged 3 commits intomainfrom
atof-fix-z-range
Apr 7, 2026
Merged

feat: update ATOF z histogram fitting range#463
Sangbaek merged 3 commits intomainfrom
atof-fix-z-range

Conversation

@zhiwanxu
Copy link
Copy Markdown
Collaborator

@zhiwanxu zhiwanxu commented Apr 7, 2026

I found the unit was used wrongly for ATOF z histogram range. Change it from (-30,25) -> (-300,300) to match the [mm] unit.

  • Changed the ATOF z histogram fitting range, all axis labels.
  • The test with p0v9 data shows correct peak location and RMS.
Screenshot 2026-04-07 at 2 28 59 PM

@zhiwanxu zhiwanxu marked this pull request as ready for review April 7, 2026 19:00
@zhiwanxu zhiwanxu requested a review from Sangbaek April 7, 2026 19:30
@Sangbaek Sangbaek changed the title ATOF z histogram fitting range feat: update ATOF z histogram fitting range Apr 7, 2026
@Sangbaek Sangbaek added the rg-l PR for Run Group L label Apr 7, 2026
@Sangbaek
Copy link
Copy Markdown
Collaborator

Sangbaek commented Apr 7, 2026

This is a minor update following the previous PR. I see no problem to merge this.

@Sangbaek Sangbaek merged commit 4f1ab56 into main Apr 7, 2026
9 checks passed
@Sangbaek Sangbaek deleted the atof-fix-z-range branch April 7, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rg-l PR for Run Group L

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants